From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0538EA0C43; Tue, 14 Sep 2021 14:48:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8481B4068F; Tue, 14 Sep 2021 14:48:15 +0200 (CEST) Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com [148.163.155.12]) by mails.dpdk.org (Postfix) with ESMTP id EA4214003C for ; Tue, 14 Sep 2021 14:48:13 +0200 (CEST) Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18E6Qwrw002873; Tue, 14 Sep 2021 05:48:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=proofpoint20171006; bh=WxkJ+2o/A7es+lx7hQNdyiGjgxhD10NBL2/Oo1tFAVA=; b=xUr7XHtHiePC3KHS9gkZjoGwEkmaz9FlP+9zYSEVA73BI6JWiO1/UBI+CkE/OJasH6G3 FzQCayFVWEaomMG3YlTAWnBiFgvZIsCzRVIV51f4LnovLPJnzIUTWZFxvcDkBCNKjfFR bQueP0AvkH1pEItDqtCn7jkymrdkkIpF5Djmt7IWTtJ1S1UoutEIPHOTE1If5lnSu8Tx 1x3KODXYBmcY+zFxc+uY5Pg0WXn3ZSC811F0ISeMoJmhicccnaPCA+/g1UZgtfcBaPqz 4Yp0yr3djAYRYvQ92Dj819h5byOffi1UWZZ2mw6svSappr4qjvaegulgPumR+YcHZY4f gw== Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2100.outbound.protection.outlook.com [104.47.70.100]) by mx0b-002c1b01.pphosted.com with ESMTP id 3b2pftrng6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 05:48:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6OTc5A9YwS2HXLTN7hjwEk48SDMu+z/+9I2wJ+9M+Ai38LpzoQ8RKAPXYhl+dggHM2gOX7+LYbaNyg2dxUXG9ejDrhp079fX+/mXQmPqiVT+kVT/H5Gmwiyy+bI8YDZguwjXx/OpLsarHGWWBlWsBzg36mU+pE2q05B3MhcV2dhxmqMwDE0xBxM12y+VlffOZMHLEV88JcwOfx66BYardaUt2yfxWFWnd9+MrAllmFWPeKr7UzD8pFBPTigfU3kU4jzyYoJ5yZVnJMFqEfENb1uicAMUJrx8+8LUznlqq3/7DVj3I/cokCIYMrhp0AxqcJtEyRZXQ+Re0Si61lp/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WxkJ+2o/A7es+lx7hQNdyiGjgxhD10NBL2/Oo1tFAVA=; b=i0X8kgxjwvlgjq/8YGIxjWoLejoB3J8uV3HRmXWmfpzjfshn8GYz2OARgpANOyCrz5rPdUtToWxGxKEs0xJ+9h+3/o7A42QoL5FVagiYMTOXFxXYzywxAu+FrslsZ10t68tKvri9ZJ3hsRH/YKacnl9Ktr2MRxpKjy1Ra3AGwQbvR8s72e/izUDBwId9zmP8nNo6GqsK/EgGSEKTYMhmW5bC1df0K7qAQshcpzBH8a5FWHAsto7+Ure5wNJc6gXl+SBXcML++w9yWDvsG6jLQLI9yZ5LiqlVhGVvS3XSg/T66UjStyzaFaVEoKbbnHn/oHZF5sMw8b8NzpnhbwfX8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none Received: from BL0PR02MB4580.namprd02.prod.outlook.com (2603:10b6:208:40::27) by BL0PR02MB5378.namprd02.prod.outlook.com (2603:10b6:208:83::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Tue, 14 Sep 2021 12:48:11 +0000 Received: from BL0PR02MB4580.namprd02.prod.outlook.com ([fe80::b9d9:2c4b:c85e:dbd0]) by BL0PR02MB4580.namprd02.prod.outlook.com ([fe80::b9d9:2c4b:c85e:dbd0%7]) with mapi id 15.20.4500.019; Tue, 14 Sep 2021 12:48:11 +0000 From: John Levon To: Dmitry Kozlyuk CC: "dev@dpdk.org" , Anatoly Burakov , Viacheslav Ovsiienko Thread-Topic: [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable Thread-Index: AQHXqVQ6nKd9qbqLnUWnEGFQgu2Af6ujeuAA Date: Tue, 14 Sep 2021 12:48:11 +0000 Message-ID: References: <20210716110806.2566788-1-dkozlyuk@nvidia.com> <20210914103456.535427-1-dkozlyuk@nvidia.com> <20210914103456.535427-2-dkozlyuk@nvidia.com> In-Reply-To: <20210914103456.535427-2-dkozlyuk@nvidia.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nutanix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1131120-e524-4f89-cd91-08d9777de912 x-ms-traffictypediagnostic: BL0PR02MB5378: x-microsoft-antispam-prvs: x-proofpoint-crosstenant: true x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mXXdQ0S5aKGJjf8e7IVg49N/j8Omn77s/NpJn7e1D/Wp7+5tocw1jxfsETihSoyW6zEtn6EqemQNzCsiJ7TVCV3OHpyYZ2Ixst7LDGH9Iqg14OAv6Q/826xpqCQlSNhpol2jByhjBzv1D/E/1KOhCy4SxhJ68LAyJLqjmgVfVoEM8N+Ad0K4hOk6WEq/hr+g5QqRfn5wBONzZ1AxhvY4p4Nfm9lFedVhi/USrdRdhWBXESDw/NcUAYQ1cVVHQMYQ2aFBWqr/mP8RLe98Zb+PPr3MmPF03P9CxbiGEthzG2ioV4we01WcXXNEPZJRuxv2G79hbdIPj8OQTt6QiV0p6obHgNqDJfn8A0iJNut2EIDqXkc3ChEBNo7LeGhglfEbUMZ2Xef9IiAlTCVDpjqLsFVaydvLKnIoXNYTGHqCCuCELcaW/SSXoDSaLGWfFSLLQNGyrSdipvR1rkEHb/zeIDg70JZpEeyBaGNKyIue2oLuDGeW1Gchu5PWVKPWX8Rdp/H5rgyRHj1ZtyXNP3wW6XKltmCO3Lw/B3ZliCiOjeCL2IC/T0aRBB+7wCaEtWladTzHbOCKomw4ZfzCeWb3+cORAWsy2cI15yaZc9mCJyOoVVJGHWdiPGR1uxbaO4F5pkjmVPMPrUS6E69eq/fB3uXyNRrcRyUckGrxx0/TZBCoLvzZwyvuTBQU76fqLp37oQwO6hrib0yhV/GxAslKAw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR02MB4580.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(39860400002)(376002)(366004)(346002)(396003)(2906002)(4326008)(86362001)(54906003)(36756003)(316002)(6512007)(66476007)(66556008)(64756008)(66946007)(76116006)(91956017)(9686003)(4744005)(186003)(71200400001)(44832011)(38100700002)(122000001)(478600001)(8936002)(26005)(6506007)(8676002)(6916009)(66446008)(6486002)(38070700005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QnkOx0QNvDLemo31s2Vqd0IskscCi6zK7siZW5G4cZGCGqmoIzl18ohySV19?= =?us-ascii?Q?jYDQJCagtR/EKBzCwiGhLfqNnXnWTmR6kl+IB7UpL8ycdaMSCc77MfVinKy9?= =?us-ascii?Q?HHHyuPNKGk3ker0CkJaesRhw62+Xc9naRmM0VwIN6K593lFnMZO1N456Pe9u?= =?us-ascii?Q?egM1J6Pibs7UVtUDxzmlvKv9OeqgDsVn4s3IniLG6J07Lwz/fYlZGNqSS+rt?= =?us-ascii?Q?CFAxMJEfQ0Ni+UlKwa2JDOzn9i6ysAUa0mIzOCmBGWmbHPUy5+A1XkVFV54n?= =?us-ascii?Q?sAO5kk13HLXBOAaWrfgGcIalUBmPyvoLMR2nmAZoA06ld2t25iZIYbyq/nLF?= =?us-ascii?Q?046XopY/BZwpLfQIpZqd/7mfbXm10Bu260CvwIutUvlHRr0B46BDaZuXEGpg?= =?us-ascii?Q?NAfrQ2nvlxXJRhuxmRmVQbsfUO38F/Ze5wwjeRNaVPE9Oo3nVnLv5+zlZvEq?= =?us-ascii?Q?IFgWSQhlaThkJaFl/5Eeu0QBjEPqKfDV+nQ88WjsIb8PRd72clnn/+DNYbG+?= =?us-ascii?Q?kGYjMtbYcZLDHJcjcdiu1zprIP2w/OaYPG1jDrb2j9oGEgcgxgyOQgC/BMiY?= =?us-ascii?Q?E2h5axTEVz2CUsYMbdAG8QwBsPdA6RNr6mnbB0csSQO9xTAlQd+HsYjY5m8M?= =?us-ascii?Q?UODYnQ8LEjGVh2QIpWoqz8xRbUOi4YT7c0Ve3f8bvk54+jU1L0f2MW8nvmW/?= =?us-ascii?Q?drCGKlaOq6z6pbQ4lIYCaEzofCZv5xDC78BrcmFhmKX9AP4BSvOYGDiSyDjy?= =?us-ascii?Q?Exzak3XvSG6JkvUIrV+3Dd2QEEKTVjvREpcKFLYQmF83bG9CEXYru4kZUFgK?= =?us-ascii?Q?a/Cb4nafcj2unAnm5jsOOyxH8GjXaGwEdJgiaWwVY7ql2PgOS6yN7LHy71af?= =?us-ascii?Q?FuiRX6TBiB68h/a0Wl0U5PG72yyTHdTWdSvOLsLVZsvrrXpRkHJ+9PNJb4pG?= =?us-ascii?Q?0MLu7FSgKD3uzwgXuWn/aNWq31lh4GVI85gJLR7rUdtMgZanE6tijnKws6f1?= =?us-ascii?Q?NUu/y/aIT6uf+A8Xhg0bDupoT13v9jBwxuvtTrAkS+YmRJzAcTtzyKU3ZKqp?= =?us-ascii?Q?ACXcfGggXst60j0UwL7mLOR9m9IrQ7QtqP5kptDVFsn/vZT96N2tKhMIIslc?= =?us-ascii?Q?WAWSVdoX0YEpVHNu/jZr6NL0GPKSaHJ1q292dfrPi2cWuu1NARciKHeTfx0X?= =?us-ascii?Q?I7A66ey76UhpChaASziCCiQDOEJ31lHX0O+lk4q6Nx9ffqFtpmdCtOTY+NuS?= =?us-ascii?Q?FGR5iZXmCEijLgrr519Pb0/tZZIpeqvWltBq+q0dHMbMOD+lWLKhNR4zA17e?= =?us-ascii?Q?cnwGWPo0KeN+zD64lSVvdLrV?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR02MB4580.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1131120-e524-4f89-cd91-08d9777de912 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2021 12:48:11.3667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: USll4Ij3lMSyIZjmsUF4h64Mr75ltEoxyPD2MotlknUNs1+essIwimx986KYVgcaVeA0vaUtSbtSSZrdxa4dlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB5378 X-Proofpoint-GUID: 1_3ogcny0jA_XQV_vl-8WRYcVY4kBqnw X-Proofpoint-ORIG-GUID: 1_3ogcny0jA_XQV_vl-8WRYcVY4kBqnw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-14_03,2021-09-14_01,2020-04-07_01 X-Proofpoint-Spam-Reason: safe Subject: Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 14, 2021 at 01:34:54PM +0300, Dmitry Kozlyuk wrote: > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > using handcraft parsing of /proc/mounts and mixing traversal logic with > selecting the needed entry. Separate code to enumerate hugetlbfs mounts > to eal_hugepage_mount_walk() taking a callback that can inspect already > parsed entries. Use mntent(3) API for parsing. This allows to reuse > enumeration logic in subsequent patches. Hi, are you planning to implement my pending change on top of this? thanks john=