From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, john.mcnamara@intel.com, david.marchand@redhat.com,
ferruh.yigit@intel.com, Ray Kinsella <mdr@ashroe.eu>,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: remove references to the old build system
Date: Wed, 15 Sep 2021 17:33:29 +0100 [thread overview]
Message-ID: <YUIgWYMIyMGa7TVp@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210915162845.3000652-1-thomas@monjalon.net>
On Wed, Sep 15, 2021 at 06:28:45PM +0200, Thomas Monjalon wrote:
> Some docs and comments in Meson files are still mentioning
> the old build system based on "make", removed in 20.11.
> After one year, such references are better to be removed.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> doc/guides/contributing/abi_versioning.rst | 3 +--
> doc/guides/linux_gsg/build_dpdk.rst | 3 +--
> doc/guides/rel_notes/release_21_11.rst | 4 ++--
> drivers/common/mlx5/linux/meson.build | 2 --
> drivers/net/mlx4/meson.build | 2 --
> drivers/net/tap/meson.build | 2 --
> 6 files changed, 4 insertions(+), 12 deletions(-)
>
<snip>
>
> - Unlike with the make build system present in older DPDK releases,
> - the meson system is not
> + The meson system is not
> designed to be used directly from a build directory. Instead it is
> recommended that it be installed either system-wide or to a known
> location in the user's home directory. The install location can be set
While the other removals look good to me, I suspect there are quite a few
users out there still working on old releases and building using make. This
comment therefore I feel could still be relevant and should be kept.
For the rest of the patch:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2021-09-15 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 16:28 Thomas Monjalon
2021-09-15 16:33 ` Bruce Richardson [this message]
2021-09-16 14:35 ` David Marchand
2021-09-23 6:47 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-09-23 6:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUIgWYMIyMGa7TVp@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).