From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95714A0C41; Wed, 15 Sep 2021 18:33:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60DAA4068F; Wed, 15 Sep 2021 18:33:37 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 443794014F for ; Wed, 15 Sep 2021 18:33:36 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="209600286" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="209600286" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:33:35 -0700 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="700288108" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.4.169]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Sep 2021 09:33:32 -0700 Date: Wed, 15 Sep 2021 17:33:29 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, john.mcnamara@intel.com, david.marchand@redhat.com, ferruh.yigit@intel.com, Ray Kinsella , Matan Azrad , Viacheslav Ovsiienko , Keith Wiles Message-ID: References: <20210915162845.3000652-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210915162845.3000652-1-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH] doc: remove references to the old build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 15, 2021 at 06:28:45PM +0200, Thomas Monjalon wrote: > Some docs and comments in Meson files are still mentioning > the old build system based on "make", removed in 20.11. > After one year, such references are better to be removed. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/contributing/abi_versioning.rst | 3 +-- > doc/guides/linux_gsg/build_dpdk.rst | 3 +-- > doc/guides/rel_notes/release_21_11.rst | 4 ++-- > drivers/common/mlx5/linux/meson.build | 2 -- > drivers/net/mlx4/meson.build | 2 -- > drivers/net/tap/meson.build | 2 -- > 6 files changed, 4 insertions(+), 12 deletions(-) > > > - Unlike with the make build system present in older DPDK releases, > - the meson system is not > + The meson system is not > designed to be used directly from a build directory. Instead it is > recommended that it be installed either system-wide or to a known > location in the user's home directory. The install location can be set While the other removals look good to me, I suspect there are quite a few users out there still working on old releases and building using make. This comment therefore I feel could still be relevant and should be kept. For the rest of the patch: Acked-by: Bruce Richardson