From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63B97A0C41; Thu, 16 Sep 2021 10:31:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 535934003F; Thu, 16 Sep 2021 10:31:51 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D620A4003E for ; Thu, 16 Sep 2021 10:31:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="209746711" X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="209746711" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 01:31:49 -0700 X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="530092058" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.206]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Sep 2021 01:31:47 -0700 Date: Thu, 16 Sep 2021 09:31:44 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com Message-ID: References: <20210915095036.22346-1-bruce.richardson@intel.com> <2152077.EyU4qHBnM4@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2152077.EyU4qHBnM4@thomas> Subject: Re: [dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 16, 2021 at 09:57:30AM +0200, Thomas Monjalon wrote: > 15/09/2021 11:50, Bruce Richardson: > > Add a note for the preference of using "()" rather than "\" for line > > continuations in meson. > > > > Suggested-by: David Marchand > > Signed-off-by: Bruce Richardson > > --- > > doc/guides/contributing/coding_style.rst | 10 ++++++++++ > > This is not the Meson guide. > "coding style guide sub-section for meson" was too long to fit in the header. :-) > > --- a/doc/guides/contributing/coding_style.rst > > +++ b/doc/guides/contributing/coding_style.rst > > @@ -1024,6 +1024,16 @@ The following guidelines apply to the build system code in meson.build files in > > * Line continuations should be doubly-indented to ensure visible difference from normal indentation. > > Any line continuations beyond the first may be singly indented to avoid large amounts of indentation. > > > > +* Where a line is split in the middle of a statement, e.g. a multiline `if` statement, > > + brackets should be used in preference to escaping the line break. > > Should we specify it is about Meson? > It's in a section entitled "Meson Coding Style"[1] so that should not be necessary. [1]https://doc.dpdk.org/guides-21.08/contributing/coding_style.html#meson-coding-style