* [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
@ 2021-09-08 10:59 Xiao Wang
2021-09-08 4:52 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Xiao Wang @ 2021-09-08 10:59 UTC (permalink / raw)
To: olivier.matz; +Cc: dev, Xiao Wang
rte_net_make_rarp_packet was introduced in version v18.02, there was no
change in this public API since then, and it's still being used by vhost
lib and virtio driver, so promote it as stable ABI.
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
lib/net/rte_arp.h | 4 ----
lib/net/version.map | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/net/rte_arp.h b/lib/net/rte_arp.h
index feb0eb3e49..076c8ab314 100644
--- a/lib/net/rte_arp.h
+++ b/lib/net/rte_arp.h
@@ -50,9 +50,6 @@ struct rte_arp_hdr {
} __rte_packed __rte_aligned(2);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Make a RARP packet based on MAC addr.
*
* @param mpool
@@ -63,7 +60,6 @@ struct rte_arp_hdr {
* @return
* - RARP packet pointer on success, or NULL on error
*/
-__rte_experimental
struct rte_mbuf *
rte_net_make_rarp_packet(struct rte_mempool *mpool,
const struct rte_ether_addr *mac);
diff --git a/lib/net/version.map b/lib/net/version.map
index 355b7c25b4..7584018d58 100644
--- a/lib/net/version.map
+++ b/lib/net/version.map
@@ -6,6 +6,7 @@ DPDK_22 {
rte_net_crc_calc;
rte_net_crc_set_alg;
rte_net_get_ptype;
+ rte_net_make_rarp_packet;
local: *;
};
@@ -13,7 +14,6 @@ DPDK_22 {
EXPERIMENTAL {
global:
- rte_net_make_rarp_packet;
rte_net_skip_ip6_ext;
rte_ether_unformat_addr;
};
--
2.15.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
2021-09-08 10:59 [dpdk-dev] [PATCH] net: promote make rarp packet API as stable Xiao Wang
@ 2021-09-08 4:52 ` Stephen Hemminger
2021-09-08 5:07 ` Xia, Chenbo
2021-09-16 11:38 ` Olivier Matz
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2021-09-08 4:52 UTC (permalink / raw)
To: Xiao Wang; +Cc: olivier.matz, dev
On Wed, 8 Sep 2021 18:59:15 +0800
Xiao Wang <xiao.w.wang@intel.com> wrote:
> rte_net_make_rarp_packet was introduced in version v18.02, there was no
> change in this public API since then, and it's still being used by vhost
> lib and virtio driver, so promote it as stable ABI.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
2021-09-08 10:59 [dpdk-dev] [PATCH] net: promote make rarp packet API as stable Xiao Wang
2021-09-08 4:52 ` Stephen Hemminger
@ 2021-09-08 5:07 ` Xia, Chenbo
2021-09-16 11:38 ` Olivier Matz
2 siblings, 0 replies; 5+ messages in thread
From: Xia, Chenbo @ 2021-09-08 5:07 UTC (permalink / raw)
To: Wang, Xiao W, olivier.matz; +Cc: dev
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiao Wang
> Sent: Wednesday, September 8, 2021 6:59 PM
> To: olivier.matz@6wind.com
> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
>
> rte_net_make_rarp_packet was introduced in version v18.02, there was no
> change in this public API since then, and it's still being used by vhost
> lib and virtio driver, so promote it as stable ABI.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
> lib/net/rte_arp.h | 4 ----
> lib/net/version.map | 2 +-
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/lib/net/rte_arp.h b/lib/net/rte_arp.h
> index feb0eb3e49..076c8ab314 100644
> --- a/lib/net/rte_arp.h
> +++ b/lib/net/rte_arp.h
> @@ -50,9 +50,6 @@ struct rte_arp_hdr {
> } __rte_packed __rte_aligned(2);
>
> /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
> * Make a RARP packet based on MAC addr.
> *
> * @param mpool
> @@ -63,7 +60,6 @@ struct rte_arp_hdr {
> * @return
> * - RARP packet pointer on success, or NULL on error
> */
> -__rte_experimental
> struct rte_mbuf *
> rte_net_make_rarp_packet(struct rte_mempool *mpool,
> const struct rte_ether_addr *mac);
> diff --git a/lib/net/version.map b/lib/net/version.map
> index 355b7c25b4..7584018d58 100644
> --- a/lib/net/version.map
> +++ b/lib/net/version.map
> @@ -6,6 +6,7 @@ DPDK_22 {
> rte_net_crc_calc;
> rte_net_crc_set_alg;
> rte_net_get_ptype;
> + rte_net_make_rarp_packet;
>
> local: *;
> };
> @@ -13,7 +14,6 @@ DPDK_22 {
> EXPERIMENTAL {
> global:
>
> - rte_net_make_rarp_packet;
> rte_net_skip_ip6_ext;
> rte_ether_unformat_addr;
> };
> --
> 2.15.1
Acked-by: Chenbo Xia <chenbo.xia@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
2021-09-08 10:59 [dpdk-dev] [PATCH] net: promote make rarp packet API as stable Xiao Wang
2021-09-08 4:52 ` Stephen Hemminger
2021-09-08 5:07 ` Xia, Chenbo
@ 2021-09-16 11:38 ` Olivier Matz
2021-10-02 8:57 ` David Marchand
2 siblings, 1 reply; 5+ messages in thread
From: Olivier Matz @ 2021-09-16 11:38 UTC (permalink / raw)
To: Xiao Wang; +Cc: dev
On Wed, Sep 08, 2021 at 06:59:15PM +0800, Xiao Wang wrote:
> rte_net_make_rarp_packet was introduced in version v18.02, there was no
> change in this public API since then, and it's still being used by vhost
> lib and virtio driver, so promote it as stable ABI.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
2021-09-16 11:38 ` Olivier Matz
@ 2021-10-02 8:57 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2021-10-02 8:57 UTC (permalink / raw)
To: Xiao Wang; +Cc: dev, Olivier Matz, Stephen Hemminger, Xia, Chenbo
On Thu, Sep 16, 2021 at 1:38 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Wed, Sep 08, 2021 at 06:59:15PM +0800, Xiao Wang wrote:
> > rte_net_make_rarp_packet was introduced in version v18.02, there was no
> > change in this public API since then, and it's still being used by vhost
> > lib and virtio driver, so promote it as stable ABI.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Chenbo Xia <chenbo.xia@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-02 8:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 10:59 [dpdk-dev] [PATCH] net: promote make rarp packet API as stable Xiao Wang
2021-09-08 4:52 ` Stephen Hemminger
2021-09-08 5:07 ` Xia, Chenbo
2021-09-16 11:38 ` Olivier Matz
2021-10-02 8:57 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).