From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA2E4A0C45; Thu, 16 Sep 2021 16:01:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2B294069E; Thu, 16 Sep 2021 16:01:53 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 1E38940151 for ; Thu, 16 Sep 2021 16:01:51 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="286254566" X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="286254566" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 07:01:45 -0700 X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="700626079" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.206]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Sep 2021 07:01:42 -0700 Date: Thu, 16 Sep 2021 15:01:39 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Ajit Khaparde , Thomas Monjalon , Farah Smith , Venkat Duvvuru , dev@dpdk.org Message-ID: References: <20210908050643.9989-1-venkatkumar.duvvuru@broadcom.com> <20210911153041.28510-1-venkatkumar.duvvuru@broadcom.com> <20210911153041.28510-5-venkatkumar.duvvuru@broadcom.com> <731cd94a-c338-660c-3604-a5b99e934256@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <731cd94a-c338-660c-3604-a5b99e934256@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 04/13] net/bnxt: add Thor SRAM mgr model X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 16, 2021 at 02:49:57PM +0100, Ferruh Yigit wrote: > On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > > diff --git a/meson_options.txt b/meson_options.txt > > index 0e92734c49..f686e6d92a 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -46,3 +46,5 @@ option('tests', type: 'boolean', value: true, description: > > 'build unit tests') > > option('use_hpet', type: 'boolean', value: false, description: > > 'use HPET timer in EAL') > > +option('bnxt_tf_wc_slices', type: 'integer', min: 1, max: 4, value: 2, > > + description: 'Number of slices per WC TCAM entry') > > -- > > > Are we sure to add a PMD specific meson option? > > I believe if we let to go this way, soon the meson options can be as messy as > Makefile config options. @Thomas, @Bruce, what do you think? Completely agree. Can this be made a runtime option, perhaps passed in as a devarg if necessary?