From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47E84A0548; Mon, 20 Sep 2021 12:27:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1A0440DF7; Mon, 20 Sep 2021 12:27:52 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 22D7A40DF5 for ; Mon, 20 Sep 2021 12:27:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="210337107" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="210337107" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 03:27:48 -0700 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="556053742" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.156]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Sep 2021 03:27:46 -0700 Date: Mon, 20 Sep 2021 11:27:43 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, fengchengwen@huawei.com, jerinj@marvell.com, conor.walsh@intel.com Message-ID: References: <20210827172048.558704-1-kevin.laatz@intel.com> <20210917152437.3270330-1-kevin.laatz@intel.com> <20210917152437.3270330-8-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210917152437.3270330-8-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH v5 07/16] dma/idxd: add configure and info_get functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 17, 2021 at 03:24:28PM +0000, Kevin Laatz wrote: > Add functions for device configuration. The info_get function is included > here since it can be useful for checking successful configuration. > Since this patch makes a change in the test code to enable use in the docs, that should be called out here too, I think, for example: "When providing an example of the function's use in the documentation, use code snippet from the unit tests".