From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B108A0548; Mon, 20 Sep 2021 12:45:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9159240DF7; Mon, 20 Sep 2021 12:45:52 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id ABF6B40DF5 for ; Mon, 20 Sep 2021 12:45:51 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="221219872" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="221219872" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 03:45:50 -0700 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="548657031" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.156]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Sep 2021 03:45:48 -0700 Date: Mon, 20 Sep 2021 11:45:45 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org, fengchengwen@huawei.com, jerinj@marvell.com, conor.walsh@intel.com Message-ID: References: <20210827172048.558704-1-kevin.laatz@intel.com> <20210917152437.3270330-1-kevin.laatz@intel.com> <20210917152437.3270330-16-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210917152437.3270330-16-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH v5 15/16] devbind: add dma device class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 17, 2021 at 03:24:36PM +0000, Kevin Laatz wrote: > Add a new class for DMA devices. Devices listed under the DMA class are to > be used with the dmadev library. > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- One small comment below to be fixed. Reviewed-by: Bruce Richardson > usertools/dpdk-devbind.py | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > index 74d16e4c4b..8bb573f4b0 100755 > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py > @@ -69,12 +69,13 @@ > network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class] > baseband_devices = [acceleration_class] > crypto_devices = [encryption_class, intel_processor_class] > +dma_devices = [] > eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso] > mempool_devices = [cavium_fpa, octeontx2_npa] > compress_devices = [cavium_zip] > regex_devices = [octeontx2_ree] > -misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx, intel_ioat_icx, intel_idxd_spr, > - intel_ntb_skx, intel_ntb_icx, > +misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx, > + intel_ioat_icx, intel_idxd_spr, intel_ntb_skx, intel_ntb_icx, This looks a purely cosmetic change, which doesn't really below in the patch - especially since a number of these entries are to move in later patches for 21.11. /Bruce