From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C92A1A0C4C; Tue, 21 Sep 2021 15:20:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9C604111D; Tue, 21 Sep 2021 15:20:58 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5B3C44003C for ; Tue, 21 Sep 2021 15:20:57 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="287025978" X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="287025978" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 06:20:56 -0700 X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="701679063" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.200]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 21 Sep 2021 06:20:55 -0700 Date: Tue, 21 Sep 2021 14:20:51 +0100 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com Message-ID: References: <20210915121104.30581-1-david.hunt@intel.com> <20210921115015.36442-1-david.hunt@intel.com> <913add5d-f7fc-dec1-bf14-01ba1ba06b1b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <913add5d-f7fc-dec1-bf14-01ba1ba06b1b@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: add additional info if core list too long X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 21, 2021 at 02:16:35PM +0100, David Hunt wrote: > On 21/9/2021 1:04 PM, David Hunt wrote: > > On 21/9/2021 12:57 PM, Bruce Richardson wrote: > > On Tue, Sep 21, 2021 at 12:50:14PM +0100, David Hunt wrote: > > If the user requests to use an lcore above 128 using -l, > the eal will exit with "EAL: invalid core list syntax" and > very little else useful information. > THis patch adds some extra information suggesting to use --lcores > so that physical cores above RTE_MAX_LCORE (default 128) can be > used. This is achieved by using the --lcores option by mapping > the logical cores in the application to physical cores. > There is no change in functionalty, just additional messages > suggesting how the --lcores option might be used for the supplied > list of lcores. For example, if "-l 12-16,130,132" is used, we > see the following additional output on the command line: > EAL: Error = One of the 7 cores provided exceeds RTE_MAX_LCORE (128) > EAL: Please use --lcores instead, e.g. > > Minor suggestion: it would be good to clarify how to use lcores and > what is > happening here in the example. Something like: "Please use --lcores > instead, to map lower lcore ids onto higher-numbered cores", could > help the > user understand better what is happening. > > Hi Bruce, how about: > EAL: Please use --lcores to map logical cores onto cores > > RTE_LCORE_MAX ,e.g. --lcores 0@12,1@13,2@14,3@15,4@16,5@130,6@132 > Rgds, > Dave. > > I think this should do it, as it clarifies the mapping: > > EAL: lcore 130 >= RTE_MAX_LCORE (128) > EAL: lcore 132 >= RTE_MAX_LCORE (128) > EAL: to use high physical core ids , please use --lcores to map them to > lcore ids below RTE_LCORE_MAX, e.g. '--lcores > 0@12,1@13,2@14,3@15,4@16,5@130,6@132' > Text looks good to me. Again minor nits: I think the continued lines should be indented, and you should probably wrap immediately after the "e.g." rather than in the middle of the parameter set. /Bruce