From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77B24A0C41; Wed, 6 Oct 2021 18:28:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E7FE4115F; Wed, 6 Oct 2021 18:28:14 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9642041136 for ; Wed, 6 Oct 2021 18:28:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="212978551" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="212978551" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:28:11 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="458481433" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.179]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Oct 2021 09:28:10 -0700 Date: Wed, 6 Oct 2021 17:28:06 +0100 From: Bruce Richardson To: "Morrissey, Sean" Cc: Thomas Monjalon , dev@dpdk.org, Conor Fogarty , david.marchand@redhat.com Message-ID: References: <20211004101058.2396458-1-sean.morrissey@intel.com> <20211004101058.2396458-2-sean.morrissey@intel.com> <16337506.YTLTIa3MyK@thomas> <2ed06f29-fabd-c8b6-0157-11d72451c045@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ed06f29-fabd-c8b6-0157-11d72451c045@intel.com> Subject: Re: [dpdk-dev] [PATCH v1 1/5] devtools: script to remove unused headers includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 06, 2021 at 04:19:46PM +0100, Morrissey, Sean wrote: > > On 06/10/2021 14:37, Thomas Monjalon wrote: > > 04/10/2021 12:10, Sean Morrissey: > > > This script can be used for removing headers flagged for removal by the > > > include-what-you-use (IWYU) tool. The script has the ability to remove > > > headers from specified sub-directories or dpdk as a whole. > > My fear is that it could flag an include as useless, > > while it is required for a different system (BSD, Windows). > > > > > Hi Thomas, > > Stephen raised a similar concern. Please see Bruce's reply here: https://patches.dpdk.org/project/dpdk/cover/20211004101058.2396458-1-sean.morrissey@intel.com/ > One additional data point. Checking the output of a run I did of IWYU a month or two ago, shows 2254 header includes that IWYU thinks should be removed. With that sort of scale of an issue, I think automation will be needed. /Bruce