From: Olivier Matz <olivier.matz@6wind.com>
To: Joyce Kong <joyce.kong@arm.com>
Cc: ruifeng.wang@arm.com, dev@dpdk.org, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic
Date: Mon, 27 Sep 2021 21:27:50 +0200 [thread overview]
Message-ID: <YVIbNtOhOaSUhGRb@arsenic.home> (raw)
In-Reply-To: <20210823032034.12688-1-joyce.kong@arm.com>
Hi Joyce,
On Sun, Aug 22, 2021 at 10:20:34PM -0500, Joyce Kong wrote:
> In stack module, remove the duplicated header file rte_atomic.h
> as it has been included in rte_spinlock.h/rte_pause.h
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Sorry for the late feedback.
No objection about the patch itself, but I don't think the commit log
should say that rte_atomic.h is indirectly included by
rte_spinlock.h/rte_pause.h.
To me, it is not a good reason to remove an include. However, it looks
that no function from rte_atomic.h is used in these files, especially
since commit c51e67c2ee18 ("test/stack: remove thread synchronisation")
for the test app.
Thanks,
Olivier
next prev parent reply other threads:[~2021-09-27 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 3:20 Joyce Kong
2021-09-27 19:27 ` Olivier Matz [this message]
2021-10-13 20:48 ` [dpdk-dev] [PATCH v2] " Dharmik Thakkar
2021-10-15 12:59 ` Olivier Matz
2021-10-19 14:02 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVIbNtOhOaSUhGRb@arsenic.home \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).