From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB6B7A0C46; Mon, 27 Sep 2021 21:28:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B3B8410DC; Mon, 27 Sep 2021 21:28:26 +0200 (CEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by mails.dpdk.org (Postfix) with ESMTP id 153CA40E3C for ; Mon, 27 Sep 2021 21:28:25 +0200 (CEST) Received: by mail-ed1-f42.google.com with SMTP id g7so14100326edv.1 for ; Mon, 27 Sep 2021 12:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4Kq8wHzw/rRdnY/5hnVSGhNuOo2CLKGys18aknaYuLM=; b=I4dQEHyBMFSVh/J80N3PRzsxV7IMsyuthKdJSH/ioYyDAd8KxS0ABKDjbwz8NhsWZm 6SJUkvObic17XuSbKTikAsR+Ov7IqMVELQG5G2dHEK6u4biS1t5IXFfoz8MDQ8vBqkbd nR+xQDXMwG8OYMObgbzzFcGdRhxyZO4GgrpO5PymPohOKRKV9mh87kV8ZIaZllNTN0A6 wo07XkePlrElTJyvYOi86E9tUGJT+OpmInG0YZuMZgRFuhkUVEFd+deYHLTVRVC3XGUw 0hYFKt8x4CDJmEnCMmycNS1qXfjEr5TxNfIg/8S/WOspqy7pN0KrE4WA/zbMh5p88Mgm ktjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4Kq8wHzw/rRdnY/5hnVSGhNuOo2CLKGys18aknaYuLM=; b=v1JDj+5Fa2UW981brGuhUqmMiuXJT8Wn96MjwWt0eRsDfoVA54n/BNYp4wNb6coMzX Ht/lycbf8JIcRLLSqjPHg3R3QR77podYGhrLDz0GK6zL/aetCCsnGkmZ/FepTtRxzEU7 ee2r7B05T2F188bjm5BZemHmqu3Y/nCOBwkUkic8M1l3UtkfVYoPuqLs+zA7ydfKn49c SECjghiKh2WtH3qoRAnAzkeHdZU+T5USuZWngoaKcEdj5GK2YnZnglk693t07mK6SRS/ XhWGFlfwAVNKprZBnanKoODUldx4nKcqLdDO3K1oH4iXyv9kBiUZBOiVOVCkXvlv/KQc gAUA== X-Gm-Message-State: AOAM532E2Q790PMYEU0dUMb8C1BtanuihIxOmVmZnBIDrjrcjq82cAtP a7Y98rNT+lf9/xBi4GcGzTpmHw== X-Google-Smtp-Source: ABdhPJxmvMQsBZyDcpaWf4hRluK4QOgV9+pfLuyO1so+AqvoRLzbXBp/k8XfLrQujoDWRla+5TA/oA== X-Received: by 2002:a05:6402:1057:: with SMTP id e23mr2270058edu.352.1632770904841; Mon, 27 Sep 2021 12:28:24 -0700 (PDT) Received: from 6wind.com ([109.190.253.14]) by smtp.gmail.com with ESMTPSA id q9sm8997817ejf.70.2021.09.27.12.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 12:28:23 -0700 (PDT) Date: Mon, 27 Sep 2021 21:27:50 +0200 From: Olivier Matz To: Joyce Kong Cc: ruifeng.wang@arm.com, dev@dpdk.org, nd@arm.com Message-ID: References: <20210823032034.12688-1-joyce.kong@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210823032034.12688-1-joyce.kong@arm.com> Subject: Re: [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Joyce, On Sun, Aug 22, 2021 at 10:20:34PM -0500, Joyce Kong wrote: > In stack module, remove the duplicated header file rte_atomic.h > as it has been included in rte_spinlock.h/rte_pause.h > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Sorry for the late feedback. No objection about the patch itself, but I don't think the commit log should say that rte_atomic.h is indirectly included by rte_spinlock.h/rte_pause.h. To me, it is not a good reason to remove an include. However, it looks that no function from rte_atomic.h is used in these files, especially since commit c51e67c2ee18 ("test/stack: remove thread synchronisation") for the test app. Thanks, Olivier