From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09C43A0032; Wed, 29 Sep 2021 23:15:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93896410EC; Wed, 29 Sep 2021 23:15:56 +0200 (CEST) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id 70991410EB for ; Wed, 29 Sep 2021 23:15:55 +0200 (CEST) Received: by mail-wm1-f45.google.com with SMTP id b192-20020a1c1bc9000000b0030cfaf18864so2701081wmb.4 for ; Wed, 29 Sep 2021 14:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7eBdxfzPLRoalBFB2oDVepwrVCOWI8jq8K8sld7CXGs=; b=hZajb4UubxCxvuVTuc5vKCI5gpNp/uOnozcQMaEZ4X06jc4Ht1+gr5NbU+jZe7Spxu e/2svNYMGcHU7mEe71KP2CBGTQV2ZvASmRt8HnBrzuckvcFAdOkwHXWjpUl2dBFyCYpk IRmwN4qHrqeduBm/OpjYJ/WucDLcZYKo/f2qDvSOWh9qIJbJ8+DWyHyjjJzmq7+wiQoa 099HIYjkAP/hsAGL/vBZ/xXbTFjUabuPNqLoznYCQtip4T+FoDlLU8jz4JLcqh4/xesp WWR1zI8CxDjxcqkVkTIWMaJaXt8D674fEyda9JdJ4RkHkdv5s5KDWOuKAnzsro+osIRP 1zMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7eBdxfzPLRoalBFB2oDVepwrVCOWI8jq8K8sld7CXGs=; b=4wJqqLpF7UX7oG2G5U4KepWBtIl7cvvWjuNgkNVuegUb0r7jzV2+apGur6HYu7w+zt mRZ5DOj2Ay3G9QaXjTsUicMBU2SWalATEcr4wO6BAhtJfjTxAzyf4KBb4XHO14UsvvDU L9KQ9hfG2ZElpHg+KtmjRo22ZAo+WQKUTM2BcU474brhek/2A0IXk02H1U8Qrd6ppOf1 5hDxDuUSFPY+sS6X6DVby3pQqoXOuYhEtz6hY9SxLOEWGNmh/Tsi+VC5OQpKx30bxTc7 MkTmgEf2heQHchXFwTxx4tH4ZDPjdn9PJl0kkVCANhZ88kINZkqsrU/9soe4306ZDtfO BBIg== X-Gm-Message-State: AOAM531Kmk3dMXB+crQ6RldXwNHhmSNiVsNDO6N+X571BdHL+/x0zTvA MdbnuX2/LN/9wm8bAFxdRI1ZDg== X-Google-Smtp-Source: ABdhPJzOue5pgHaSAepomAqzC+rTOUIEJAl7cgGWtgNGa1hbc5L3XDca0puRGXYEPS76v8ejbGwthQ== X-Received: by 2002:a05:600c:4e86:: with SMTP id f6mr2065918wmq.166.1632950155180; Wed, 29 Sep 2021 14:15:55 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id o26sm2764342wmc.17.2021.09.29.14.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Sep 2021 14:15:54 -0700 (PDT) Date: Wed, 29 Sep 2021 23:15:53 +0200 From: Olivier Matz To: Maxime Coquelin Cc: david.marchand@redhat.com, chenbo.xia@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: References: <20210929201739.176306-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929201739.176306-1-maxime.coquelin@redhat.com> Subject: Re: [dpdk-dev] [PATCH] net/virtio: revert forcing IOVA as VA mode for virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Maxime, On Wed, Sep 29, 2021 at 10:17:39PM +0200, Maxime Coquelin wrote: > This patch removes the simplification in Virtio descriptors > handling, where their buffer addresses are IOVAs for Virtio > PCI devices, and VA-only for Virtio-user devices, which > added a requirement on Virtio-user that it only supported > IOVA as VA. > > This change introduced a regression for applications using > Virtio-user and other physical PMDs that require IOVA as PA > because they don't use an IOMMU. > > This patch reverts to the old behaviour, but needed to be > reworked because of the refactoring that happened in v21.02. > > Fixes: 17043a2909bb ("net/virtio: force IOVA as VA mode for virtio-user") > Cc: stable@dpdk.org > > Reported-by: Olivier Matz > Signed-off-by: Maxime Coquelin Tested-by: Olivier Matz Many thanks for your quick solution on this!