From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F78EA0C41; Thu, 30 Sep 2021 16:00:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66CD6410EB; Thu, 30 Sep 2021 16:00:30 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id E891D410E5 for ; Thu, 30 Sep 2021 16:00:28 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id v17so10216629wrv.9 for ; Thu, 30 Sep 2021 07:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ea7GHk9y3r+xhurSHvkw5zjaCsjkgRgw+VlpV5u3yrU=; b=ZJ8AsxdlHEQdpvwq+jX1QNTyK1A6yv2RSvEWysCu3Z2DsHMjlPfsjDUw24otblPy9E eyTPKGSn4g4G8K3onP1StOm9oc3RFTwTnvWY3atD77H7lTACJt5B9X/OOiyo29KvpDzZ mrSlgI4qvVSVb8ZsG4WQIT0aLy/UzqWp0XiavxsNfRyhduZXReha0VYUW3eJKo8D489Z t+ug7xEg+EtFeyJHEpr3X5OOYWOgbH2yOZY4+xhS9f8pNv2hyPGPE+jvei8m2EY0HoMQ Y3BvvagTjp1TJrUtF9dqroPnwpfwuBKKYPnD2H+WUeLeA2ULWd72IKNG5PMdqLfANn3O 0LbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ea7GHk9y3r+xhurSHvkw5zjaCsjkgRgw+VlpV5u3yrU=; b=fDCF/yswKHHWV4c82isDvdKl/avuN7GnvvCjdRWHhrW1YV0iqfWagWYxJ2MwBp1N5a 2YPpmCRyWzIe/VxHlzNwp4EIFeBKuXs99rAae5/lHvG/tSn01Gaxx40yoUZfsOThkf1J /PdNgznBU+9QWC+/D/anmKDJaCRj3gjp6Me6r2MDnMhKsSJsaU9kj7qS3aC9Tdtz6VDr RoegUmlkwHKXdF1kdBfUA7K4FAcrPC3cZ/CiJex+EQTUWgIUCINYuQQntcDOPjLA6BZ+ WcERjjaq3LwBkXF6c3E9w4DUOwaVNnRTAFX0ih46d5tZtvKuzeM8SuvaxtOsbUPTBPXp UKjg== X-Gm-Message-State: AOAM532ik/pYe3sAGVAm2wmLNeFDp+/FWPkjrOXnJHZdIIAn7AlnNzlx qoHJUrydCRpYqUv6rKKV2e22vIhFWBpx1A== X-Google-Smtp-Source: ABdhPJwcRksiPmlJ1R6CvDThEELSMxryazZUPia2GfqleIT972FpjSLrNgRH9cJRYUkhjifgcX9BPg== X-Received: by 2002:adf:e805:: with SMTP id o5mr6296683wrm.249.1633010428697; Thu, 30 Sep 2021 07:00:28 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id q9sm2379156wrx.4.2021.09.30.07.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 07:00:28 -0700 (PDT) Date: Thu, 30 Sep 2021 16:00:26 +0200 From: Olivier Matz To: dev@dpdk.org, David Marchand Cc: Bruce Richardson , Xueming Li , Gaetan Rivet , Ray Kinsella Message-ID: References: <20210924155740.20510-1-olivier.matz@6wind.com> <20210929213943.17817-1-olivier.matz@6wind.com> <20210929213943.17817-5-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929213943.17817-5-olivier.matz@6wind.com> Subject: Re: [dpdk-dev] [PATCH v2 4/5] kvargs: remove experimental function to compare string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 29, 2021 at 11:39:42PM +0200, Olivier Matz wrote: > The function was designed to be used as a handler for > rte_kvargs_process() to compare the value string in a kvlist. For > readability, its usages in DPDK have been replaced by > rte_kvargs_get_with_value() in previous commit. > > Remove this function, as it is not used anymore. > > Signed-off-by: Olivier Matz > Reviewed-by: Xueming Li Maybe a quick note could be added in the release note. Something like this: * kvargs: The experimental function ``rte_kvargs_strcmp()`` has been removed. Its usages have been replaced by a new function ``rte_kvargs_get_with_value()``. David, do you want me to send a v3 with this note? Thanks, Olivier