From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CC8CA0032; Fri, 1 Oct 2021 12:12:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEF244067A; Fri, 1 Oct 2021 12:12:43 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id C996840040 for ; Fri, 1 Oct 2021 12:12:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="222191028" X-IronPort-AV: E=Sophos;i="5.85,337,1624345200"; d="scan'208";a="222191028" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 03:12:41 -0700 X-IronPort-AV: E=Sophos;i="5.85,337,1624345200"; d="scan'208";a="618996816" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.10.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Oct 2021 03:12:38 -0700 Date: Fri, 1 Oct 2021 11:12:34 +0100 From: Bruce Richardson To: David Marchand Cc: William Tu , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Thomas Monjalon , dpdk-dev , Nick Connolly , Omar Cardona , Pallavi Kadam Message-ID: References: <20210823130343.87247-1-u9012063@gmail.com> <20210824162103.32783-1-u9012063@gmail.com> <20210920201111.GA7448@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20211001123605.00fa6402@sovereign> <20211001125117.28f546b2@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 01, 2021 at 11:55:47AM +0200, David Marchand wrote: > On Fri, Oct 1, 2021 at 11:51 AM Dmitry Kozlyuk wrote: > > > > 2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > > > 2021-10-01 09:27 (UTC+0200), David Marchand: > > > > [...] > > > > I just have a concern that headers get broken again if we have no check. > > > > Could buildtools/chkincs do the job (if we make this check work on Windows)? > > > > > > It's a valid caoncern and yes, chkincs would be a solution. > > Talked with Thomas, in any case, we can proceed with this patch. > > The check is something to add/make work the sooner the better. > > > > > > > I discovered that the real issue with chkincs was a space after shebang in > > > gen_c_file_for_header.py. If it is removed, find_program() is able to parse > > > the line and call the script with Python interpreter. However, spaces > > > *are* allowed after shebangs. Would you like me to submit a patch with a fix > > > just chkincs or shall I *instead* work with meson developers (I'll do that > > > anyway)? I'm asking because we have other files with extra spaces, so there's > > > a question if we should fix them, add a rule for the space, etc. > > > > Just re-checked with meson 0.57.0 (as recommended in Windows GSG) and hit no > > issue even with a space after "#!". Maybe it was a meson 0.47 issue on > > Windows at the time you disabled chkins there? > > Maybe, I am not sure, Bruce had put this limitation. > I'm not sure either, sorry.