From: Bruce Richardson <bruce.richardson@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows
Date: Fri, 1 Oct 2021 17:39:16 +0100 [thread overview]
Message-ID: <YVc5tFzX4hMWqVs7@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20211001163726.78308-3-dmitry.kozliuk@gmail.com>
On Fri, Oct 01, 2021 at 07:37:26PM +0300, Dmitry Kozlyuk wrote:
> Independent header compilation test (chkincs) was disabled on Windows.
> The comment stated that the shebang line in the generator script was not
> working. Meson 0.57.0, currently recommended for Windows, successfully
> parses that line and invokes the script. Remove the OS restriction
> as its reason no longer applies.
>
> Fixes: 05050ac4ce99 ("build: add header includes check")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2021-10-01 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 16:37 [dpdk-dev] [PATCH 0/2] " Dmitry Kozlyuk
2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
2021-10-11 19:07 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-10-24 21:58 ` Dmitry Kozlyuk
2021-10-01 16:37 ` [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
2021-10-01 16:39 ` Bruce Richardson [this message]
2021-10-11 19:10 ` [dpdk-dev] [PATCH 0/2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVc5tFzX4hMWqVs7@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).