From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07EA5A0C4C; Mon, 4 Oct 2021 11:46:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 997FF41301; Mon, 4 Oct 2021 11:46:31 +0200 (CEST) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mails.dpdk.org (Postfix) with ESMTP id 2C5D741300 for ; Mon, 4 Oct 2021 11:46:31 +0200 (CEST) Received: by mail-wr1-f52.google.com with SMTP id v25so18984145wra.2 for ; Mon, 04 Oct 2021 02:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fLk2YG2XonJa0SZ0yFMpQScKomshL9i3HzEDsYkXRMI=; b=dHb5vTq/Uul7gW0Bn1dq+jfUYLV0JCesPNjS3c1qE8iAjWAr2NemlWf9yNYL5+ncDJ Vbe1LE1ui2nITKATfz5Rguyg1e1sMSmFXlXV2jKc+en1hEobOu7x4aiHVNrfPh9V5dSs VIWdJDvKGYzLLAyksrqGcvTt7FkkeJZwSIX5pn8OtP4iRVdCwwNciV5qPPTOm/M5+oNH FCTC4iZvp63C5pPF0mNP5n8EjojisyFxIO641XDHdJ9NdE0kKawMDlq3/RC9sEwjPedP qjrVbUBnaYrjeVL4ab7oMpaTpH6luzbGgsHdHK7P+yIzVs3U5xtIR76tkjGH8qYWA79w X2hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fLk2YG2XonJa0SZ0yFMpQScKomshL9i3HzEDsYkXRMI=; b=YyavIngeSdwdOAPC40L3g6U6jW+prkrMbiMg1WqqQ9VeoPA7+9bligkodZlEeia/OV tvmx1FH8DaWzwkuaB2GjKkIWQqxr5TBWWa+Mfs4YURw3zYD/XHIYI1NI5e6khmxjJk3G c2+OoJvmZztEj7oSwpZKX5MIlaVZdED413VHVJ7/JkIxhzrQ2NaKzcR7frYVNBPXfUbc 7fRMNYkoOll2dlLKLetQuCAM2cxJ5/jytQsBdQsv4v4pzeOhLchn6+npVlRCndwQBu1S 95jBuqtaNqEYcNxD7n8qrIwEEnhXXjjn3U4cCytvXnXfEjUbbcY0sagCzLC8gp63jHKc OZaw== X-Gm-Message-State: AOAM533ouTPHgL4JbJLCVmDLgHJj1YOojTW58DfCRGGx/2W/c1jTw5V8 aPp2k+5vZ/hRD8nRu4nwmVs2Kw== X-Google-Smtp-Source: ABdhPJyKJWPhVtuLlL1EZtXZfLnZ3p/eoJt1ps45CoSorwv/4QO8AFZ+zVuBagvH7viXjVY9zIJgqQ== X-Received: by 2002:adf:a347:: with SMTP id d7mr13335120wrb.139.1633340790761; Mon, 04 Oct 2021 02:46:30 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id g1sm16763034wmk.2.2021.10.04.02.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 02:46:29 -0700 (PDT) Date: Mon, 4 Oct 2021 11:46:29 +0200 From: Olivier Matz To: David Marchand Cc: dev , Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon Message-ID: References: <20210929214817.18082-1-olivier.matz@6wind.com> <20210929214817.18082-2-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf: remove deprecated offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, Thank you for the review, my comments below. On Mon, Oct 04, 2021 at 10:29:36AM +0200, David Marchand wrote: > On Wed, Sep 29, 2021 at 11:50 PM Olivier Matz wrote: > > > > The flags PKT_TX_VLAN_PKT, PKT_TX_QINQ_PKT, PKT_RX_EIP_CKSUM_BAD are > > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated > > VLAN flags") (2017). Remove their definitions from rte_mbuf_core.h, > > and replace their usages. > > The patch lgtm except the removal of some "bad checksum" flags, see below. > > [snip] > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index 05fc2fdee7..549e9416c4 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -159,11 +159,6 @@ Deprecation Notices > > will be limited to maximum 256 queues. > > Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. > > > > -* ethdev: The offload flag ``PKT_RX_EIP_CKSUM_BAD`` will be removed and > > - replaced by the new flag ``PKT_RX_OUTER_IP_CKSUM_BAD``. The new name is more > > - consistent with existing outer header checksum status flag naming, which > > - should help in reducing confusion about its usage. > > - > > * i40e: As there are both i40evf and iavf pmd, the functions of them are > > duplicated. And now more and more advanced features are developed on iavf. > > To keep consistent with kernel driver's name > > Those 3 flags are easy to replace, but some projects are still using them. > > $ git grep-all -El > '\<(PKT_TX_VLAN_PKT|PKT_TX_QINQ_PKT|PKT_RX_EIP_CKSUM_BAD)\>' |grep -v > \\.patch$ > DPVS/src/netif.c > DPVS/src/vlan.c > FD.io-VPP/src/plugins/dpdk/device/format.c > gatekeeper/bpf/bpf_mbuf.h > lagopus/src/dataplane/dpdk/worker.c > packet-journey/app/main.c > Trex/src/pal/common/common_mbuf.h > Trex/src/pal/linux/mbuf.h > > Please update the release notes to announce this API update. I will add an additional note in the release note. FYI, the flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT were not marked RTE_DEPRECATED because their deprecation is older than this macro. If needed, I can keep them for one more version in the header file. > [snip] > > > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > > index 9d8e3ddc86..93db9292c0 100644 > > --- a/lib/mbuf/rte_mbuf_core.h > > +++ b/lib/mbuf/rte_mbuf_core.h > > @@ -55,37 +55,12 @@ extern "C" { > > /** RX packet with FDIR match indicate. */ > > #define PKT_RX_FDIR (1ULL << 2) > > > > -/** > > - * Deprecated. > > - * Checking this flag alone is deprecated: check the 2 bits of > > - * PKT_RX_L4_CKSUM_MASK. > > - * This flag was set when the L4 checksum of a packet was detected as > > - * wrong by the hardware. > > - */ > > -#define PKT_RX_L4_CKSUM_BAD (1ULL << 3) > > - > > -/** > > - * Deprecated. > > - * Checking this flag alone is deprecated: check the 2 bits of > > - * PKT_RX_IP_CKSUM_MASK. > > - * This flag was set when the IP checksum of a packet was detected as > > - * wrong by the hardware. > > - */ > > -#define PKT_RX_IP_CKSUM_BAD (1ULL << 4) > > - > > You did not mention PKT_RX_IP_CKSUM_BAD and PKT_RX_L4_CKSUM_BAD in the > commitlog. > There was no deprecation notice, and those flags were not marked > RTE_DEPRECATED (there are still many projects referencing them). > > Is this removal intended? Yes, actually these flags were defined twice at different places. I'm just removing one occurence, and the other remains. Thanks, Olivier