From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4F39A0C43; Mon, 18 Oct 2021 10:35:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A489D410E4; Mon, 18 Oct 2021 10:35:59 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 55635410E1 for ; Mon, 18 Oct 2021 10:35:58 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id u8-20020a05600c440800b0030d90076dabso5633401wmn.1 for ; Mon, 18 Oct 2021 01:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GcjOduqd7+eTkBGeuS7Tg0GIVxCZRGjHO1kLjVDw8WM=; b=bQLMB5ljem8YLQU9VU5X5lWnnoVsXtRzIznh933SEAvLxG3D0w+dYgA82GPJjLrB+K FWhmYEvcoRUJEX5/zwoFMnCIZfiQHGJOmCSRS7eFQbWhpB5hpy810b0n8q8sXgR1zh2S gVW2yws+A1/pkaam91ze9FFUaHoTziUVroM2x1fsGtcOhXtlO2CLk60DpqEAIs+BXc1S iLNMu+tz+F+ze13AHto6d7yZnixc4myYWQctlxPwrZO3xqedKmX1bLQ5jzErLlIB3I9O bUCn7CzPcpKpj4Lm7zdVnAVAOof/KpvIokAEJnYIdO8JJdY7MqKPGP14WDZpvE0LoAqe tyig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GcjOduqd7+eTkBGeuS7Tg0GIVxCZRGjHO1kLjVDw8WM=; b=1HgVb8euQ6BOp7LadRYYlOmrxbtS0ptH4nV/7dvr4+1Gx9CfqUtRGTTi1zXbZ++x6/ SCH9RheBzIsF4elZRgeo0W/ip1cN+m+pxXKIrkGVDbd5XLccHqjrqzERwbsAnLDOgSAL 3T0tHgVoaol2j/t7jVj9wC5WAPJwB6zzplpc7nfJTaBQuUhTrpfIr4/gyFogrEXE1Dud V5W0kzTNxHjd0GPrJlxcUX4AYWp+xsSqye9n8wC5KL2hkOokkN2Xma7SDEDc6oRX45Bi K/q+omZHPDlku0Jeq/uChLSePg5DrrXiXhevReHocyjoreMroksIXL4YJquuL3wzmKVR WBCg== X-Gm-Message-State: AOAM530jEKcDRD6ioR1SFkhAjdQPM//l6lzNnHhkBCRwSq/cl/krdcrp Fg+Pf8CI7bgdbl2L/XOzg1L7xA== X-Google-Smtp-Source: ABdhPJwxDatffLXiQi6AHtHQSgmykjSi5nzE9OD7A34+BqNmFOhunxeS4As8KOJYdMJLoLgbvdaS0w== X-Received: by 2002:a1c:27c3:: with SMTP id n186mr28993880wmn.192.1634546158093; Mon, 18 Oct 2021 01:35:58 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id a5sm11946681wrn.71.2021.10.18.01.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 01:35:57 -0700 (PDT) Date: Mon, 18 Oct 2021 10:35:57 +0200 From: Olivier Matz To: David Marchand Cc: dev@dpdk.org, Dmitry Kozlyuk , Andrew Rybchenko , Ray Kinsella , Stephen Hemminger Message-ID: References: <20211018082635.2054-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018082635.2054-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH] mempool: accept user flags only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 18, 2021 at 10:26:35AM +0200, David Marchand wrote: > As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated > internally. > This flag is not supposed to be requested from an application and would > probably result in an incorrect behavior if an application did pass it. > > Other internal flags may be introduced later. > > Rework the check and export a mask of valid user flags for use in the > unit test. > > Fixes: b240af8b10f9 ("mempool: enforce valid flags at creation") > > Reported-by: Dmitry Kozlyuk > Signed-off-by: David Marchand Acked-by: Olivier Matz