From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DA60A0547; Tue, 19 Oct 2021 14:43:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 992EF4115B; Tue, 19 Oct 2021 14:43:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3AD55410FA for ; Tue, 19 Oct 2021 14:43:14 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="314697611" X-IronPort-AV: E=Sophos;i="5.87,384,1631602800"; d="scan'208";a="314697611" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 05:43:13 -0700 X-IronPort-AV: E=Sophos;i="5.87,384,1631602800"; d="scan'208";a="483204349" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.14.183]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Oct 2021 05:43:11 -0700 Date: Tue, 19 Oct 2021 13:43:08 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, aconole@redhat.com, blo@iol.unh.edu Message-ID: References: <20211018170136.5189-1-david.marchand@redhat.com> <20211019112602.17782-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019112602.17782-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 01:26:02PM +0200, David Marchand wrote: > Cores count has a direct impact on the time needed to complete unit > tests. > > Currently, the core list used for unit test is enforced to "all cores on > the system" with no way for (CI) users to adapt it. > On the other hand, EAL default behavior (when no -c/-l option gets passed) > is to start threads on as many cores available in the process cpu > affinity. > > Remove logic from meson: users can then select where to run the tests by > either running meson with a custom cpu affinity (using taskset/cpuset > depending on OS) or by passing a --test-args option to meson. > > Example: > $ sudo meson test -C build --suite fast-tests -t 3 --test-args "-l 0-3" > > Signed-off-by: David Marchand > --- Tested using ring_perf_autotest. By default this ran perf tests on multiple threads, cores and numa nodes. Passing in `--test-args="-l 0-3"` the tests only ran on the multiple cores option as no threads on multiple numa nodes, or no threads sharing a core were present. Tested-by: Bruce Richardson Acked-by: Bruce Richardson