From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AB63A0547; Tue, 19 Oct 2021 18:15:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0370B41109; Tue, 19 Oct 2021 18:15:13 +0200 (CEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 700D7410FC for ; Tue, 19 Oct 2021 18:15:12 +0200 (CEST) Received: by mail-wm1-f47.google.com with SMTP id d198-20020a1c1dcf000000b00322f53b9b89so3923598wmd.0 for ; Tue, 19 Oct 2021 09:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7OwgUNRNnXaVKaWCAcgfGFBx4a/fRKkLhtshiewSdEk=; b=ZUI4u8/EVZYySbHevSM5CBrG1260Ln6mM2JTCn6YEIL/gb0b94sbg/SKIoXjCl9Gj+ pZMdWdPvPZKN8M2ZVXgFF5PNxrAz371TcjMe7wYlr2kcaLba1eUikbWOQiDH4Evx6mzu GuurFilCjTY2cU1htGUxKX2SeplTtJQO4s0x//8mpgb2UtvAoup26P/hFI707mYSjP0k RjMI3tMT/GaZb71hV4KR1bds/JMlXJdYsb+CqRpM/QX5L7ujUCBoUuToAYxK/fT1+9wD 4ny6IIEOpDKV73bGWPacMHZQLA/GNp2KKSgo5s7Lss8eYqkMoR28//fgFDYVR591ZiSF VZCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7OwgUNRNnXaVKaWCAcgfGFBx4a/fRKkLhtshiewSdEk=; b=wJVF+eaejFNe4Qxa9Qj7yQYkKNuZ82sNRmGResa+zBq0JezQU7VhJaf85hvFV9pNjg NyyVz4bonO4HoZHvr6NAeMXPMwBAkJKq6vQhMrFg+Ts3qAbwQGuylux7LL6kTk+HShp6 xnCfRUPE0m/qXfbpTPa0VfKQGMPTFW+etu/FrEKB43U3Hv8H6fla6GvYG684VFhtSEUu g+MGAKhTLpmAZAd7Bo/IR+CJylv85IMnCoEnyvbWmqnkk0SZ82RnSYiF0HU885uU1yTX Qmclgn09OcV2j/x2yNfikkVylv3Daba5ubzsy//XrrJDc1BuWmIJf5QN3LtziLLBQlra t+nQ== X-Gm-Message-State: AOAM531pADpsdeDUQFRFzKBRrogd2AymWSlgYPh5nTMNjLQUi2zaL1jR RI0I4mea4jMK8XVHoz1/duyNug== X-Google-Smtp-Source: ABdhPJzdbyUAd/tOLEAo5yoPsEZWFdSDmo7q8fV108M8X6QaHioYx0PujzOVipvhX47Dj3t8IwBGKA== X-Received: by 2002:a5d:4a0c:: with SMTP id m12mr45842320wrq.27.1634660112218; Tue, 19 Oct 2021 09:15:12 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id i17sm17981075wru.18.2021.10.19.09.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 09:15:11 -0700 (PDT) Date: Tue, 19 Oct 2021 18:15:11 +0200 From: Olivier Matz To: Andrew Rybchenko Cc: David Marchand , Maryam Tahhan , Reshma Pattan , Xiaoyun Li , Pavan Nikhilesh , Shijith Thotton , Jerin Jacob , "Artem V. Andreev" , Nithin Dabilpuram , Kiran Kumar K , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , dev@dpdk.org Message-ID: References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211019100845.1632332-1-andrew.rybchenko@oktetlabs.ru> <20211019100845.1632332-3-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 2/6] mempool: add namespace prefix to flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 06:13:54PM +0200, Olivier Matz wrote: > On Tue, Oct 19, 2021 at 01:08:41PM +0300, Andrew Rybchenko wrote: > > Fix the mempool flgas namespace by adding an RTE_ prefix to the name. > > nit: flgas -> flags > > > The old flags remain usable, to be deprecated in the future. > > > > Signed-off-by: Andrew Rybchenko > > (...) > > > @@ -777,12 +777,12 @@ rte_mempool_cache_free(struct rte_mempool_cache *cache) > > rte_free(cache); > > } > > > > -#define MEMPOOL_KNOWN_FLAGS (MEMPOOL_F_NO_SPREAD \ > > - | MEMPOOL_F_NO_CACHE_ALIGN \ > > - | MEMPOOL_F_SP_PUT \ > > - | MEMPOOL_F_SC_GET \ > > - | MEMPOOL_F_POOL_CREATED \ > > - | MEMPOOL_F_NO_IOVA_CONTIG \ > > +#define MEMPOOL_KNOWN_FLAGS (RTE_MEMPOOL_F_NO_SPREAD \ > > + | RTE_MEMPOOL_F_NO_CACHE_ALIGN \ > > + | RTE_MEMPOOL_F_SP_PUT \ > > + | RTE_MEMPOOL_F_SC_GET \ > > + | RTE_MEMPOOL_F_POOL_CREATED \ > > + | RTE_MEMPOOL_F_NO_IOVA_CONTIG \ > > ) > > I guess MEMPOOL_KNOWN_FLAGS was kept as is on purpose. > I forgot to add the ack Acked-by: Olivier Matz