From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8A27A0547; Tue, 19 Oct 2021 18:21:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B075F40683; Tue, 19 Oct 2021 18:21:05 +0200 (CEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 235374003E for ; Tue, 19 Oct 2021 18:21:04 +0200 (CEST) Received: by mail-wm1-f49.google.com with SMTP id g39so8670760wmp.3 for ; Tue, 19 Oct 2021 09:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TFyU0hTHycJ7eGDYI2V+SdxLiX5wEkNgK7tF7/sa6Sg=; b=cYuWhYHhVjwS0pUl5j8M0ZOTCOlFb0sFA85MB0nqJOhbBR+8Bff4Pbh4Dn+B0sydWr Ku6K8dHgcjPM++rnLs5s5d0pAaTKcR0hPRZfE78SdZMrY+BiuXuoV3rEdRdcukK3/UyW nW6Qg0GRZ5uaOjg0cxUFGuX/qCQKkSl2W2oXigg0m9R3sIvou8ksU1DPQC9qoVzhCIes myRXkjR3Qwc7/BjOd10ve155JVc8pYF7u+vPAVTY3JYZ3vhPp1xxAfq/ojeK7+LXW3nV 858a4hpFtaX84LwX5KZ6Eula3JNvOCOC/ZHVF1p5pqPA6Hy3AjHyOAwfnYwMwHcnxkLN Jakg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TFyU0hTHycJ7eGDYI2V+SdxLiX5wEkNgK7tF7/sa6Sg=; b=D9w2pHDharCPo6vmfwDRJlB/Vq8wUzW/vj8Cx0JNObEM3AcAvTV4fZs+WiPjEB2gFN kqNtbbJQ7UFYfe076dnHywLJWG1a6/fgRF66oHIzt7HZXLAR4Kai1v7mggCq213Q4MES iRPW52KCYIzNRxq3PVcPuwE6c+IeBcfTZYDXR8ynPsOUWN2ntlVRa2nvfapfn5vROC7I WWgC1RYjJaItfxP33f+bCOMeFSZOc2Bajbddrq15RBi2M3SIFhubbFazAWkZKvssKyuE hHLSJd/bb4MzqgFfP6KOTsiCKWQpBs6tUSgzhMi+YvaUNqj/RhZ/+/W03voNnLWd7+Rb 4xqw== X-Gm-Message-State: AOAM5326S7a+snPYYSxfrQVDS30dvy69ZCAVOtqIsvMDvFpFwt0etvVb uCDmpZTwGXqS8F7gzVIV++uf2g== X-Google-Smtp-Source: ABdhPJw3e++MMxeMQDoZIzy7u3Tn4lwOqCW0jEXv/bfiizWng+e7UTLK7pe2F+y+UIjMdjSw0M+hjg== X-Received: by 2002:a7b:c444:: with SMTP id l4mr7022675wmi.115.1634660463978; Tue, 19 Oct 2021 09:21:03 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id t1sm6000691wre.32.2021.10.19.09.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 09:21:03 -0700 (PDT) Date: Tue, 19 Oct 2021 18:21:02 +0200 From: Olivier Matz To: Andrew Rybchenko Cc: David Marchand , Ray Kinsella , dev@dpdk.org Message-ID: References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211019100845.1632332-1-andrew.rybchenko@oktetlabs.ru> <20211019100845.1632332-7-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019100845.1632332-7-andrew.rybchenko@oktetlabs.ru> Subject: Re: [dpdk-dev] [PATCH v2 6/6] mempool: deprecate unused defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 01:08:45PM +0300, Andrew Rybchenko wrote: > MEMPOOL_PG_NUM_DEFAULT and MEMPOOL_PG_SHIFT_MAX are not used. > > Signed-off-by: Andrew Rybchenko Fixes: fd943c764a63 ("mempool: deprecate xmem functions") ? > --- a/lib/mempool/rte_mempool.h > +++ b/lib/mempool/rte_mempool.h > @@ -116,10 +116,11 @@ struct rte_mempool_objsz { > /* "MP_" */ > #define RTE_MEMPOOL_MZ_FORMAT RTE_MEMPOOL_MZ_PREFIX "%s" > > -#define MEMPOOL_PG_SHIFT_MAX (sizeof(uintptr_t) * CHAR_BIT - 1) > +#define MEMPOOL_PG_SHIFT_MAX \ > + RTE_DEPRECATED(sizeof(uintptr_t) * CHAR_BIT - 1) > > -/** Mempool over one chunk of physically continuous memory */ > -#define MEMPOOL_PG_NUM_DEFAULT 1 > +/** Deprecated. Mempool over one chunk of physically continuous memory */ > +#define MEMPOOL_PG_NUM_DEFAULT RTE_DEPRECATED(1) > Same comment than previous patches here. Thanks Andrew for this series!