From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5F34A034F; Fri, 8 Oct 2021 17:33:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A69C740140; Fri, 8 Oct 2021 17:33:45 +0200 (CEST) Received: from movementarian.org (ssh.movementarian.org [139.162.205.133]) by mails.dpdk.org (Postfix) with ESMTP id C74F940040 for ; Fri, 8 Oct 2021 17:33:43 +0200 (CEST) Received: from movement by movementarian.org with local (Exim 4.94) (envelope-from ) id 1mYrsQ-001RF3-KD; Fri, 08 Oct 2021 16:33:38 +0100 Date: Fri, 8 Oct 2021 16:33:38 +0100 From: John Levon To: Thomas Monjalon Cc: Anatoly Burakov , Dmitry Kozlyuk , dev@dpdk.org, Viacheslav Ovsiienko Message-ID: References: <20210920125302.820273-1-dkozlyuk@nvidia.com> <20210921081632.858873-1-dkozlyuk@nvidia.com> <20210921081632.858873-2-dkozlyuk@nvidia.com> <6865489.msH5K5uqSb@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6865489.msH5K5uqSb@thomas> X-Url: http://www.movementarian.org/ Subject: Re: [dpdk-dev] [PATCH v5 1/3] eal/linux: make hugetlbfs analysis reusable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 05, 2021 at 07:36:21PM +0200, Thomas Monjalon wrote: > 21/09/2021 10:16, dkozlyuk@oss.nvidia.com: > > From: Dmitry Kozlyuk > > > > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > > using handcraft parsing of /proc/mounts and mixing traversal logic with > > selecting the needed entry. Separate code to enumerate hugetlbfs mounts > > to eal_hugepage_mount_walk() taking a callback that can inspect already > > parsed entries. Use mntent(3) API for parsing. This allows to reuse > > enumeration logic in subsequent patches. > > > > Signed-off-by: Dmitry Kozlyuk > > Reviewed-by: Viacheslav Ovsiienko > > First version was sent in July. > Anatoly, please are you available to review? Any progress on these? Since now my original patch ("eal: allow hugetlbfs sub-directories") is going to have to wait behind this series, since nobody responded to review of the last version. Is it usual in DPDK to have to wait months? thanks john