From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62160A0C4D; Wed, 13 Oct 2021 10:28:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA04E41181; Wed, 13 Oct 2021 10:28:46 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 6E71E41162 for ; Wed, 13 Oct 2021 10:28:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="250794765" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="250794765" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 01:28:44 -0700 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="442192895" Received: from batkinso-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.25.241]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Oct 2021 01:28:43 -0700 Date: Wed, 13 Oct 2021 09:28:40 +0100 From: Bruce Richardson To: Sarosh Arif Cc: dev@dpdk.org Message-ID: References: <20211013072303.157394-1-sarosh.arif@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013072303.157394-1-sarosh.arif@emumba.com> Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd: add promiscuous mode selection through command line option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 13, 2021 at 12:23:03PM +0500, Sarosh Arif wrote: > The default behaviour of l2fwd is to exit if we are unable to turn > promiscuous mode on. On some aws instances turning promiscuous mode > on is not permitted. In such cases there should be a way to run the > application without promiscuous mode. > > This patch allows user to turn promiscuous mode on via command line > parameter. l3fwd has a similar option available. > > Signed-off-by: Sarosh Arif > --- This is a behaviour change, but since this is sample application, I think it's acceptable, and agree that the change is needed. Acked-by: Bruce Richardson