DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Rebecca Troy <rebecca.troy@intel.com>
Cc: dev@dpdk.org, ciara.power@intel.com, roy.fan.zhang@intel.com,
	Akhil Goyal <gakhil@marvell.com>,
	Declan Doherty <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5] cryptodev: add telemetry callbacks
Date: Wed, 13 Oct 2021 17:08:48 +0100	[thread overview]
Message-ID: <YWcEkMGh+s9RPf6E@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20211013152206.148589-1-rebecca.troy@intel.com>

On Wed, Oct 13, 2021 at 03:22:05PM +0000, Rebecca Troy wrote:
> The cryptodev library now registers commands with telemetry, and
> implements the corresponding callback functions. These commands
> allow a list of cryptodevs to be queried, as well as info and stats
> for the corresponding cryptodev.
> 
> An example usage can be seen below:
> 
> Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2
> {"version": "DPDK 21.11.0-rc0", "pid": 1135019, "max_output_len": 16384}
> --> /
> {"/": ["/", "/cryptodev/info", "/cryptodev/list", "/cryptodev/stats", ...]}
> --> /cryptodev/list
> {"/cryptodev/list": [0,1,2,3]}
> --> /cryptodev/info,0
> {"/cryptodev/info": {"device_name": "0000:1c:01.0_qat_sym", \
> 	 "max_nb_queue_pairs": 2}}
> --> /cryptodev/stats,0
> {"/cryptodev/stats": {"enqueued_count": 0, "dequeued_count": 0, \
> 	"enqueue_err_count": 0, "dequeue_err_count": 0}}
> 
> Signed-off-by: Rebecca Troy <rebecca.troy@intel.com>
> Acked-by: Ciara Power <ciara.power@intel.com>
> 
> ---
> v5:
>  - Added missing telemetry dependency to meson.build.

Just FYI: This addition is harmless but actually unnecessary, since
telemetry is automatically added as a recursive dependency since EAL uses
the telemetry lib.

Patch LGTM.

/Bruce

  reply	other threads:[~2021-10-13 16:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 10:21 [dpdk-dev] [PATCH] " Rebecca Troy
2021-08-20 12:59 ` Zhang, Roy Fan
2021-09-28 10:47 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-09-28 10:48 ` Akhil Goyal
2021-09-29  5:14 ` Gowrishankar Muthukrishnan
2021-09-29  7:51   ` Bruce Richardson
2021-10-07 10:17 ` [dpdk-dev] " Rebecca Troy
2021-10-07 14:11   ` [dpdk-dev] [PATCH v3] " Rebecca Troy
2021-10-12 14:30     ` Power, Ciara
2021-10-13 10:22     ` [dpdk-dev] [PATCH v4] " Rebecca Troy
2021-10-13 10:57       ` Power, Ciara
2021-10-13 12:15       ` Tal Shnaiderman
2021-10-13 15:22       ` [dpdk-dev] [PATCH v5] " Rebecca Troy
2021-10-13 16:08         ` Bruce Richardson [this message]
2021-10-25  4:32         ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-26  8:22           ` Troy, Rebecca
2021-10-26 12:00         ` [dpdk-dev] [PATCH v6] " Rebecca Troy
2021-10-26 14:37           ` [dpdk-dev] [EXT] " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWcEkMGh+s9RPf6E@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=rebecca.troy@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).