From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEAA8A0C55; Wed, 13 Oct 2021 18:09:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70113410E7; Wed, 13 Oct 2021 18:09:54 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0814B40E64 for ; Wed, 13 Oct 2021 18:09:52 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="208264096" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="208264096" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 09:08:54 -0700 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="524684845" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.25.241]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Oct 2021 09:08:52 -0700 Date: Wed, 13 Oct 2021 17:08:48 +0100 From: Bruce Richardson To: Rebecca Troy Cc: dev@dpdk.org, ciara.power@intel.com, roy.fan.zhang@intel.com, Akhil Goyal , Declan Doherty Message-ID: References: <20211013102214.108814-1-rebecca.troy@intel.com> <20211013152206.148589-1-rebecca.troy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013152206.148589-1-rebecca.troy@intel.com> Subject: Re: [dpdk-dev] [PATCH v5] cryptodev: add telemetry callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 13, 2021 at 03:22:05PM +0000, Rebecca Troy wrote: > The cryptodev library now registers commands with telemetry, and > implements the corresponding callback functions. These commands > allow a list of cryptodevs to be queried, as well as info and stats > for the corresponding cryptodev. > > An example usage can be seen below: > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 21.11.0-rc0", "pid": 1135019, "max_output_len": 16384} > --> / > {"/": ["/", "/cryptodev/info", "/cryptodev/list", "/cryptodev/stats", ...]} > --> /cryptodev/list > {"/cryptodev/list": [0,1,2,3]} > --> /cryptodev/info,0 > {"/cryptodev/info": {"device_name": "0000:1c:01.0_qat_sym", \ > "max_nb_queue_pairs": 2}} > --> /cryptodev/stats,0 > {"/cryptodev/stats": {"enqueued_count": 0, "dequeued_count": 0, \ > "enqueue_err_count": 0, "dequeue_err_count": 0}} > > Signed-off-by: Rebecca Troy > Acked-by: Ciara Power > > --- > v5: > - Added missing telemetry dependency to meson.build. Just FYI: This addition is harmless but actually unnecessary, since telemetry is automatically added as a recursive dependency since EAL uses the telemetry lib. Patch LGTM. /Bruce