From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41767A0C4E; Fri, 15 Oct 2021 14:58:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D113411D8; Fri, 15 Oct 2021 14:58:14 +0200 (CEST) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 255A4410F1 for ; Fri, 15 Oct 2021 14:58:13 +0200 (CEST) Received: by mail-wr1-f43.google.com with SMTP id u18so26479496wrg.5 for ; Fri, 15 Oct 2021 05:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jIgCrrUlpdtstjCq4m/FTQUN3j9n1nKydJlC229P78k=; b=I64OWVIzYT2ymI7jAXLn1/48CqooGyXvI3M/GYne40UxuCXTL480q37F4VjXEJ7Bmr g4Um+eUz0ISQk+JjM4rU0YdO6j+GtkPArKfrJr7hHqMySIgQxNDJa/F47M+EPuxAVOXb qm3YjJb6R21EUvblAi2GYn+wODRZ5jJ0oboge0HS5mjpdKNysIiiI42R3IhwUEDkeIHG s15COoNcqHeqMhi3tQWqqekofzk7/u/cbJflN/Yz5Xv6SJZw0zhiTcDCrn1n1PZqzauM zFQUftWugQOv5Df8ofZopK/rjbMg9LPZiqqgzezc8QP+KZUqVq2XU9PBjdzn7m29vqmo ObMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jIgCrrUlpdtstjCq4m/FTQUN3j9n1nKydJlC229P78k=; b=B9zjmB0MIpgdzlHI+/klIrb+f2tR3cF2EgZ9Ha3CNrbfgULgxSeUNXcn2bI/xbnZiE 8jtZ31N4U3Tb5luwlXYtru/vgXqLMTYaEDmr8UFapXR4TwzEpEM7+yZo61nNaSlr6oz3 bQwclsvAODtSz73UV58bdLiHZOoSNWsBGDtOHs7bSuEfSYJXxMczePDGGGJqewtUZspZ felGS4BghSRqFJWiwW6Lxwfg0mAtqWQhSScdVtHKK+9Z9nOct2qdVl/rywTL2gXyLNIc nBXnVA/SaDcLjyTlRbSeuvW1Y6QepHGkT/zEkHe4P7mk6G9V4rhZ3W9jKf1j/NNH6quT aGQw== X-Gm-Message-State: AOAM530pxraKF8RmvFvHfHpBe2dTOBzHjdK5j0RcbVH4h/Dqkyw+ixgx Mj7DSTQl0jNC8W5prNSz/EvTmQ== X-Google-Smtp-Source: ABdhPJyrnQHIUai0xAxYjD+VT0FWVuSSu0qKbavoxHmX+WEnVQEodamx6bztqHdG4oqFVFuQlJx+5g== X-Received: by 2002:adf:aa04:: with SMTP id p4mr14256453wrd.67.1634302692965; Fri, 15 Oct 2021 05:58:12 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id o6sm6449155wri.49.2021.10.15.05.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 05:58:12 -0700 (PDT) Date: Fri, 15 Oct 2021 14:58:11 +0200 From: Olivier Matz To: zhihongx.peng@intel.com Cc: dmitry.kozliuk@gmail.com, dev@dpdk.org, stable@dpdk.org Message-ID: References: <20211008064131.369133-1-zhihongx.peng@intel.com> <20211013015223.1155876-1-zhihongx.peng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013015223.1155876-1-zhihongx.peng@intel.com> Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 13, 2021 at 01:52:22AM +0000, zhihongx.peng@intel.com wrote: > From: Zhihong Peng > > Malloc cl in the cmdline_stdin_new function, so release in the > cmdline_stdin_exit function is logical, so that cl will not be > released alone. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org As said by Dmitry, we should not backport this fix to avoid breaking external apps. > Signed-off-by: Zhihong Peng I suggest to merge the 2 patches in one, because the second is mandatory when the first one is applied. Thanks Zhihong, and thanks Dmitry for the previous review.