From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64CDAA0C4E; Fri, 15 Oct 2021 14:25:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB80F411CB; Fri, 15 Oct 2021 14:25:00 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id B480C410F1 for ; Fri, 15 Oct 2021 14:24:59 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id g25so26093457wrb.2 for ; Fri, 15 Oct 2021 05:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e01aHxvlK3V/GNhFYedb+9hERWfN5OIgoGYooSf0bW8=; b=foF+JzrFKkr700Sn/j/ZD/jGqv0e/4H89yJ0dvZmAysW4WGUyau9ilpu3DLQXaxew5 RSg/MZx2tgBCTf8/RcXdDEK3wNp+IvSKyDe9LLtIAnx7yo41KqftTVDnycCxEfhKDcQw nrP5dZjkKn3eJKh0lfI3q2HdEqUBFAqvQvk0fcwiLD33NhCc0ff5cV1RwyBqZuxYPH3G 1no6XPI4mHMQaJ/YD3knHAo70YzVwvHt7WDLBoz0NkvtRoJ+8NG96TrjhEiPWBsq9Gsv +GE9+P4M9zhG+IwNoMsS2pZK23A9EJ3HM/+OpVjqb0qnpVFwD8QfswH8v6vUZMUcWgNM bdSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e01aHxvlK3V/GNhFYedb+9hERWfN5OIgoGYooSf0bW8=; b=VtRxt+E6aALpMdLHM3Q7/o41ABXGrbGe+VF7JBrMl3bykZcAuSEF8VU2ZDvm+BddPK syd2X9Tk8dvaWaKLIFtf/swsDRpqQH/YpPKXqfv5ZtDfItKImROxV6ngs2N/HQljwNac eOmKn9g4RYZFgO++W9R/31e9/pj/9LnNAYsWJuz0X0+4lDeLaZ+EzPH1xsRLVfNKsxPd roejVPDU+lbrUwAq5bclwcRsfxbFplHRy54l6NBzebh6iAedIRcsIQJrWjXMqbTGHVwa u0pfSqI8v8jKgdWiSDsk3YuF+ngSKGvBL3lcRNU2C+ke6JK29wtiwJadfj2yW1OwATO+ lQpQ== X-Gm-Message-State: AOAM533Ru+oVt2zEgNTu6KTeRw4fRkXDKo2X1fyOAVKMQYLrCVCzFY0G 3A7ASEJkU8DAwGICMy5JXfmVmQ== X-Google-Smtp-Source: ABdhPJzO7Ic72jQzk004q8csc2I8jKtTtnAuX6LAD/shfddrdQu5VJT9QcpThlkZ+zldC5PNx6M24A== X-Received: by 2002:adf:bb08:: with SMTP id r8mr14481685wrg.247.1634300699445; Fri, 15 Oct 2021 05:24:59 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id q14sm10303814wmq.4.2021.10.15.05.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 05:24:58 -0700 (PDT) Date: Fri, 15 Oct 2021 14:24:58 +0200 From: Olivier Matz To: "Morrissey, Sean" Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com Message-ID: References: <20211006111329.152938-1-sean.morrissey@intel.com> <20211007102557.188739-1-sean.morrissey@intel.com> <20211007102557.188739-5-sean.morrissey@intel.com> <10e70b00-a44f-ae6d-c16d-0935e81ec764@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10e70b00-a44f-ae6d-c16d-0935e81ec764@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 4/5] lib/kvargs: remove unneeded header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 15, 2021 at 10:20:06AM +0100, Morrissey, Sean wrote: > > On 15/10/2021 10:00, Olivier Matz wrote: > > Hi Sean, > > > > On Thu, Oct 07, 2021 at 10:25:56AM +0000, Sean Morrissey wrote: > > > These header includes have been flagged by the iwyu_tool > > > and removed. > > > > > > Signed-off-by: Sean Morrissey > > > --- > > > lib/kvargs/rte_kvargs.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c > > > index 38e9d5c1ca..4cce8e953b 100644 > > > --- a/lib/kvargs/rte_kvargs.c > > > +++ b/lib/kvargs/rte_kvargs.c > > > @@ -7,7 +7,6 @@ > > > #include > > > #include > > > -#include > > > #include > > > #include "rte_kvargs.h" > > > -- > > > 2.25.1 > > > > > Did you check that it still compiles for the Windows platform > > after this change? > > > > +CC Dmitry > > Hi Olivier, > > I cross-compiled with MinGW-64 after this change and it still compiled. Thanks. However I see that strdup() is used in rte_kvargs.c, and it is defined in lib/eal/windows/include/rte_os_shim.h. So at first glance, it seems a better option to keep the include as it is. I don't know if strdup() is defined somewhere else on windows, or if rte_os_shim.h is included by another header. Better have an opinion from a windows maintainer if we want to remove this include.