From: Georg Sauthoff <mail@gms.tf>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] net: fix aliasing issue in checksum computation
Date: Sat, 16 Oct 2021 19:17:05 +0200 [thread overview]
Message-ID: <YWsJEeMEPakpnBVJ@dell12.lru.li> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86C44@smartserver.smartshare.dk>
Hello,
On Sat, Oct 16, 2021 at 10:21:03AM +0200, Morten Brørup wrote:
> I have given this some more thoughts.
>
> Most bytes transferred in real life are transferred in large packets,
> so faster processing of large packets is a great improvement!
>
> Furthermore, a quick analysis of a recent packet sample from an ISP
> customer of ours shows that less than 8 % of the packets are odd size.
> Would you consider adding an unlikely() to the branch handling the odd
> byte at the end?
sure, I don't see a problem with adding unlikely() there.
I'll post a version 2 of that patch then, tomorrow.
Best regards
Georg
--
"No one can write decently who is distrustful of the reader's
intelligence, or whose attitude is patronizing." (William Strunk,
Jr. and E.B. White, The Elements of Style, p. 70, 1959)
next prev parent reply other threads:[~2021-10-16 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 11:49 [dpdk-dev] [PATCH 0/1] " Georg Sauthoff
2021-09-18 11:49 ` [dpdk-dev] [PATCH 1/1] " Georg Sauthoff
2021-10-14 17:20 ` Ferruh Yigit
2021-10-14 20:22 ` Morten Brørup
2021-10-16 8:21 ` Morten Brørup
2021-10-16 17:17 ` Georg Sauthoff [this message]
2021-10-16 8:24 ` Morten Brørup
2021-10-15 14:39 ` Olivier Matz
2021-10-16 17:02 ` Georg Sauthoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWsJEeMEPakpnBVJ@dell12.lru.li \
--to=mail@gms.tf \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).