From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CF8AA0C47; Wed, 27 Oct 2021 15:08:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D64E407FF; Wed, 27 Oct 2021 15:08:19 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id C3ED24068C for ; Wed, 27 Oct 2021 15:08:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="316359272" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="316359272" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 06:08:16 -0700 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="447543409" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.16.125]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Oct 2021 06:08:14 -0700 Date: Wed, 27 Oct 2021 14:08:09 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org Message-ID: References: <20211026142045.2996949-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211026142045.2996949-1-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 26, 2021 at 02:20:45PM +0000, Kevin Laatz wrote: > When checking if the DMA device is active, the result of the operand will > always be zero since the err_code is truncated to 8 bits which makes > checking the 31st bit impossible. > > This is fixed by changing the type of err_code to uint32_t so that it is > not truncated. > > Coverity issue: 373657 > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > > Signed-off-by: Kevin Laatz > --- Acked-by: Bruce Richardson