From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson
Date: Tue, 2 Nov 2021 18:05:09 +0000 [thread overview]
Message-ID: <YYF91cynVwsyDnGy@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8wrjWX7TOzNZaWyrgmRx861N46i3PStSJQtQygKfz6b9w@mail.gmail.com>
On Tue, Nov 02, 2021 at 06:48:07PM +0100, David Marchand wrote:
> On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > I wonder is there ever any scenario where we want to allow tabs on a line?
> > If not, then rather than using regex, the check could be simplified to:
> >
> > if '\t' in line:
>
> I am not sure.
> I considered cases with tabs in log messages.
>
Ok. I think we'd live without tabs in log messages if we had to, but for
now your version is safer as it allows us to keep everything else
unchanged.
/Bruce
next prev parent reply other threads:[~2021-11-02 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 20:55 David Marchand
2021-10-27 9:57 ` Bruce Richardson
2021-11-02 17:48 ` David Marchand
2021-11-02 18:05 ` Bruce Richardson [this message]
2021-11-02 18:23 ` David Marchand
2021-11-02 18:15 ` Stephen Hemminger
2021-11-02 18:22 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYF91cynVwsyDnGy@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).