Re: [dpdk-dev] [PATCH] meson.build: replace tabs with spaces

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Nov 02, 2021 at 08:50:55AM -0700, Stephen Hemminger wrote:
> Per the meson recommendation the meson.build file
> should be indented with spaces not tabs.
> This patch is semi-automatically generated by running
> all the meson.build files through expand command.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> Note: if users (like me) just editconfig setup in their
> favorite editor, this would not be a problem.
> 
> Also, shouldn't checkpatch be made smarter to catch this?
> 
>  app/pdump/meson.build                 |  6 +--
>  app/proc-info/meson.build             |  6 +--
>  app/test-acl/meson.build              |  6 +--
>  app/test-bbdev/meson.build            |  8 ++--
>  app/test-cmdline/meson.build          |  6 +--
>  app/test-compress-perf/meson.build    |  6 +--
>  app/test-crypto-perf/meson.build      |  6 +--
>  app/test-eventdev/meson.build         |  6 +--
>  app/test-fib/meson.build              |  6 +--
>  app/test-flow-perf/meson.build        |  6 +--
>  app/test-pipeline/meson.build         |  6 +--
>  app/test-regex/meson.build            |  6 +--
>  app/test-sad/meson.build              |  6 +--
>  app/test/meson.build                  |  6 +--
>  config/meson.build                    | 60 +++++++++++++--------------
>  drivers/compress/octeontx/meson.build |  6 +--
>  drivers/crypto/cnxk/meson.build       |  6 +--
>  drivers/crypto/ipsec_mb/meson.build   | 38 ++++++++---------
>  drivers/crypto/qat/meson.build        |  2 +-
>  drivers/net/ice/meson.build           |  2 +-
>  20 files changed, 100 insertions(+), 100 deletions(-)
> 

Yes, this should be caught automatically, and David M. has already proposed
a patch to automatically check for this [1].

For your patch specifically, most of the tabs need to be replaced by
4-chars rather than 8-chars of space. The last indent (drivers/net/ice) is
the one exception, I believe, and requires an 8-space indent.

Regards,
/Bruce

[1] http://patches.dpdk.org/project/dpdk/patch/20211022205531.9966-1-david.marchand@redhat.com/