From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44D77A0C4E; Tue, 2 Nov 2021 17:32:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C6354069F; Tue, 2 Nov 2021 17:32:44 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7C2C440689 for ; Tue, 2 Nov 2021 17:32:43 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="294763991" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="294763991" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 09:19:24 -0700 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="667177428" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.189]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Nov 2021 09:19:18 -0700 Date: Tue, 2 Nov 2021 16:19:14 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org, Reshma Pattan , Maryam Tahhan , Konstantin Ananyev , Nicolas Chautru , Olivier Matz , Declan Doherty , Ciara Power , Jerin Jacob , Vladimir Medvedkin , Wisam Jaddo , Cristian Dumitrescu , Ori Kam , Bernard Iremonger , Ashish Gupta , Fiona Trahe , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Fan Zhang , Pablo de Lara , John Griffin , Deepak Kumar Jain , Qiming Yang , Qi Zhang Message-ID: References: <20211102155055.214735-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211102155055.214735-1-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH] meson.build: replace tabs with spaces X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 02, 2021 at 08:50:55AM -0700, Stephen Hemminger wrote: > Per the meson recommendation the meson.build file > should be indented with spaces not tabs. > This patch is semi-automatically generated by running > all the meson.build files through expand command. > > Signed-off-by: Stephen Hemminger > --- > Note: if users (like me) just editconfig setup in their > favorite editor, this would not be a problem. > > Also, shouldn't checkpatch be made smarter to catch this? > > app/pdump/meson.build | 6 +-- > app/proc-info/meson.build | 6 +-- > app/test-acl/meson.build | 6 +-- > app/test-bbdev/meson.build | 8 ++-- > app/test-cmdline/meson.build | 6 +-- > app/test-compress-perf/meson.build | 6 +-- > app/test-crypto-perf/meson.build | 6 +-- > app/test-eventdev/meson.build | 6 +-- > app/test-fib/meson.build | 6 +-- > app/test-flow-perf/meson.build | 6 +-- > app/test-pipeline/meson.build | 6 +-- > app/test-regex/meson.build | 6 +-- > app/test-sad/meson.build | 6 +-- > app/test/meson.build | 6 +-- > config/meson.build | 60 +++++++++++++-------------- > drivers/compress/octeontx/meson.build | 6 +-- > drivers/crypto/cnxk/meson.build | 6 +-- > drivers/crypto/ipsec_mb/meson.build | 38 ++++++++--------- > drivers/crypto/qat/meson.build | 2 +- > drivers/net/ice/meson.build | 2 +- > 20 files changed, 100 insertions(+), 100 deletions(-) > Yes, this should be caught automatically, and David M. has already proposed a patch to automatically check for this [1]. For your patch specifically, most of the tabs need to be replaced by 4-chars rather than 8-chars of space. The last indent (drivers/net/ice) is the one exception, I believe, and requires an 8-space indent. Regards, /Bruce [1] http://patches.dpdk.org/project/dpdk/patch/20211022205531.9966-1-david.marchand@redhat.com/