From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6485FA0C43; Mon, 15 Nov 2021 10:29:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52B794113C; Mon, 15 Nov 2021 10:29:11 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id DCD4F40141 for ; Mon, 15 Nov 2021 10:29:09 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="214132745" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="214132745" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 01:28:51 -0800 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="671445413" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.213]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Nov 2021 01:28:49 -0800 Date: Mon, 15 Nov 2021 09:28:46 +0000 From: Bruce Richardson To: Dmitry Kozlyuk Cc: dev@dpdk.org, Konstantin Ananyev Subject: Re: [PATCH 2/3] buildtools: make AVX512 check script portable Message-ID: References: <20211112214826.333853-1-dmitry.kozliuk@gmail.com> <20211112214826.333853-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211112214826.333853-3-dmitry.kozliuk@gmail.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Nov 13, 2021 at 12:48:25AM +0300, Dmitry Kozlyuk wrote: > buildtools/binutils-avx512-check.sh was Unix-only > and could not be used in cross builds: > 1) written in shell; > 2) used the assembler binary that may be missing, > e.g. when building on Windows with LLVM; > 3) located the assembler as ${AS:-as} and referenced objdump, > but those binaries may be overridden via --cross-file. > > Rewrite the script in Python. > Use the C compiler for the check. > Locate objdump and the C compiler using Meson. > > Signed-off-by: Dmitry Kozlyuk > --- > buildtools/binutils-avx512-check.py | 21 +++++++++++++++++++++ > buildtools/binutils-avx512-check.sh | 16 ---------------- > buildtools/meson.build | 4 +++- > 3 files changed, 24 insertions(+), 17 deletions(-) > create mode 100644 buildtools/binutils-avx512-check.py > delete mode 100755 buildtools/binutils-avx512-check.sh > > diff --git a/buildtools/binutils-avx512-check.py b/buildtools/binutils-avx512-check.py > new file mode 100644 > index 0000000000..a4e14f3593 > --- /dev/null > +++ b/buildtools/binutils-avx512-check.py > @@ -0,0 +1,21 @@ > +#! /usr/bin/env python3 > +# SPDX-License-Identitifer: BSD-3-Clause > +# Copyright(c) 2020 Intel Corporation > + This probably should have your own copyright instead of or alongside the Intel one, since this is a rewrite. Otherwise: Acked-by: Bruce Richardson