From: Bruce Richardson <bruce.richardson@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, leyi.rong@intel.com,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [PATCH 3/3] config/x86: fix MinGW cross build with meson 0.49
Date: Mon, 15 Nov 2021 09:30:19 +0000 [thread overview]
Message-ID: <YZIoqyF/crt+g86+@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20211112214826.333853-4-dmitry.kozliuk@gmail.com>
On Sat, Nov 13, 2021 at 12:48:26AM +0300, Dmitry Kozlyuk wrote:
> Cross build with MinGW was broken for the baseline meson 0.49.2.
> Cause: in c_args = '-mno-avx512f' from config/x86/cross-mingw,
> each character was treated as a separate compiler option:
>
> meson.build:4:0: ERROR: Compiler x86_64-w64-mingw32-gcc can not compile programs.
>
> With c_args = ['-mno-avx512f'] configuration passed, but build failed,
> because Meson placed -mno-avx512f after -mavx512f in CFLAGS:
>
> In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-win32/include/immintrin.h:55,
> from /usr/lib/gcc/x86_64-w64-mingw32/9.3-win32/include/x86intrin.h:32,
> from ../dpdk/lib/net/net_crc_avx512.c:13:
> /usr/lib/gcc/x86_64-w64-mingw32/9.3-win32/include/avx512fintrin.h:1650:1:
> error: inlining failed in call to always_inline _mm512_ternarylogic_epi64:
> target specific option mismatch
> 1650 | _mm512_ternarylogic_epi64 (__m512i __A, __m512i __B, __m512i __C,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../dpdk/lib/net/net_crc_avx512.c:59:9: note: called from here
> 59 | return _mm512_ternarylogic_epi64(tmp0, tmp1, data_block, 0x96);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Additionally, -m[no-]avx512f flag is expected to be in machine_args
> by all the checks in meson.build files.
>
> Commit 419c6e9af69e ("net/i40e: fix build for Windows MinGW")
> fixed the errors cause by MinGW using AVX512F on Windows.
> The binutils AVX512F bug check is now portable,
> so enable it for Windows to switch AVX512 support on and off
> without any special logic for MinGW.
>
> Fixes: 549bfc83168f ("config: disable AVX512 with MinGW")
> Cc: leyi.rong@intel.com
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2021-11-15 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 21:48 [PATCH 0/3] config/x86: improve AVX512 availability check Dmitry Kozlyuk
2021-11-12 21:48 ` [PATCH 1/3] config/x86: skip GNU binutils bug check for LLVM Dmitry Kozlyuk
2021-11-15 9:17 ` Bruce Richardson
2021-11-12 21:48 ` [PATCH 2/3] buildtools: make AVX512 check script portable Dmitry Kozlyuk
2021-11-15 9:28 ` Bruce Richardson
2021-11-12 21:48 ` [PATCH 3/3] config/x86: fix MinGW cross build with meson 0.49 Dmitry Kozlyuk
2021-11-15 9:30 ` Bruce Richardson [this message]
2021-11-17 8:42 ` [PATCH 0/3] config/x86: improve AVX512 availability check Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZIoqyF/crt+g86+@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=konstantin.ananyev@intel.com \
--cc=leyi.rong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).