From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59C28A0032; Tue, 16 Nov 2021 15:10:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2486E40141; Tue, 16 Nov 2021 15:10:32 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6AC7240040 for ; Tue, 16 Nov 2021 15:10:30 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="232419992" X-IronPort-AV: E=Sophos;i="5.87,239,1631602800"; d="scan'208";a="232419992" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 06:10:29 -0800 X-IronPort-AV: E=Sophos;i="5.87,239,1631602800"; d="scan'208";a="506445524" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.20.107]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Nov 2021 06:10:26 -0800 Date: Tue, 16 Nov 2021 14:10:23 +0000 From: Bruce Richardson To: David Marchand Cc: Vladimir Medvedkin , dev , Thomas Monjalon , "Ananyev, Konstantin" , Lance Richardson , Ji@dpdk.org, Kai , Yipeng Wang , Sameh Gobriel Subject: Re: [PATCH v2] hash: fix thash gfni implementation Message-ID: References: <20211109172456.147140-1-vladimir.medvedkin@intel.com> <20211112141719.232932-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 02:53:49PM +0100, David Marchand wrote: > On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin > wrote: > > > > 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 > > due to the lack of support by some compilers. > > Ok, it was the initial report from Lance. > > > 2. This patch checks if AVX512F is supported along with GFNI. > > This is done if the code is built on a platform that supports GFNI, > > but does not support AVX512. > > Ok. > > > 3. Also this patch fixes compilation problems on 32bit arch due to > > lack of support for _mm_extract_epi64() by implementing XOR folding > > with _mm_extract_epi32() on 32-bit arch. > > This code is under a #if defined(__GFNI__) && defined(__AVX512F__). > > Does such a 32 bits processor exist, that supports AVX512 and GFNI? > The processor would be 64-bit but the code could well be 32-bit, and even then can still use these AVX512 instruction sets. /Bruce