From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7674A0C41; Wed, 17 Nov 2021 09:55:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC47441104; Wed, 17 Nov 2021 09:55:47 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 9AA4F40040 for ; Wed, 17 Nov 2021 09:55:45 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="233854776" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="233854776" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 00:55:44 -0800 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="472657418" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.204]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Nov 2021 00:55:43 -0800 Date: Wed, 17 Nov 2021 08:55:39 +0000 From: Bruce Richardson To: Jerin Jacob Cc: Elena Agostini , Ferruh Yigit , "dev@dpdk.org" , Slava Ovsiienko Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine Message-ID: References: <20211029204909.21318-1-eagostini@nvidia.com> <20211111214141.26612-1-eagostini@nvidia.com> <20211111214141.26612-2-eagostini@nvidia.com> <569619d5-12fc-4338-3042-3581074ad3a9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 17, 2021 at 12:51:13AM +0530, Jerin Jacob wrote: > On Wed, Nov 17, 2021 at 12:44 AM Elena Agostini wrote: > > > > > From: Jerin Jacob > > > > > Date: Tuesday, 16 November 2021 at 20:09 > > > > > To: Ferruh Yigit > > > > > Cc: Elena Agostini , dev@dpdk.org , Slava Ovsiienko > > > > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > > > On Tue, Nov 16, 2021 at 11:42 PM Ferruh Yigit wrote: > > > > > > > > > > > > On 11/16/2021 6:06 PM, Elena Agostini wrote: > > > > > > > > From: Ferruh Yigit > > > > > > > > > > > > > > > Date: Tuesday, 16 November 2021 at 19:00 > > > > > > > > > > > > > > > To: Elena Agostini > > > > > > > > > > > > > > > Cc: dev@dpdk.org , Slava Ovsiienko > > > > > > > > > > > > > > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > > > > > > > > > > > > > > > External email: Use caution opening links or attachments> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/11/2021 9:41 PM, eagostini@nvidia.com wrote: > > > > > > > > > > > > > > > > --- a/app/test-pmd/meson.build > > > > > > > > > > > > > > > > +++ b/app/test-pmd/meson.build > > > > > > > > > > > > > > > > @@ -32,7 +32,7 @@ if dpdk_conf.has('RTE_HAS_JANSSON') > > > > > > > > > > > > > > > > ext_deps += jansson_dep > > > > > > > > > > > > > > > > endif > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci'] > > > > > > > > > > > > > > > > +deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci', 'gpudev']> > > > > > > > > > > > > > > > I didn't review the set, but in a very high level do we want to add > > > > > > > > > > > > > > > 'gpudev' as dependency? Isn't this like adding 'rawdev' as dependency. > > > > > > > > > > > > > > gpudev is a library that can be built without a gpu driver as all the other libraries > > > > > > > > > > > > > > and itis actually used only in case of GPU memory mempool. > > > > > > > > > > > > > > Reasons for this patch are: > > > > > > > > > > > > > > - Have an upstreamed benchmark tool to measure network metrics using GPU memory > > > > > > > > > > > > > > - Test some DPDK features not really tested anywhere like the external memory mempool feature > > > > > > > > > > > > > > > > > > > I can see the reason, that is obvious, yet again why we are not adding rawdev > > > > > > testing to the testpmd? But adding gpudev. > > > > > > It is easier to add it to the testpmd, and for some testing perspective it > > > > > > makes sense, but still I am not quite sure about this new dependency, I would > > > > > > like to get more feedback. > > > > > > > > > > I had the similar concern earlier. IMO, It is better to have a > > > > > separate test application for gpudev like > > > > > other device classes. For eventdev cases when it needs to work with > > > > > ethdev for Rx adapter cases, > > > > > We have enabled such code in app/test-eventdev to make testpmd focus on ethdev. > > > > > > > > gpudev already has a test app in app/test-gpudev. > > > > > > > > gpudev needs to be also test with network card and today another application > > > > decidated to test gpudev over the network would be very similar to testpmd io. > > > > > > > > At this stage, there is no point in reinventing the wheel > > > I think, it is not about not reinventing the wheel, It is about > maintenance of testpmd, > currently, the feature are specific to ethdev. Adding more > cross-device-specific features > will populate the testpmd. I had a similar case when it network cases > need to be integrated to eventdev, > I choose to have it test-eventdev so that testpmd focus remains for ethdev. Since there is an increasing push for libraries to be able to be disabled in DPDK, at minimum I would look to have gpudev as an optional dependency here, so that disabling it would not completely disable building testpmd. Regards, /Bruce