From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CFDFA034F; Mon, 6 Dec 2021 10:17:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0645B4013F; Mon, 6 Dec 2021 10:17:05 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 2C5D740040 for ; Mon, 6 Dec 2021 10:17:03 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10189"; a="224532501" X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="224532501" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 01:17:02 -0800 X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="461735439" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.16.231]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Dec 2021 01:17:00 -0800 Date: Mon, 6 Dec 2021 09:16:57 +0000 From: Bruce Richardson To: Lewis Donzis Cc: dev , yongwang@vmware.com, konstantin.ananyev@intel.com Subject: Re: vmxnet3 no longer functional on DPDK 21.11 Message-ID: References: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com> <1909271468.2730688.1638755553311.JavaMail.zimbra@donzis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1909271468.2730688.1638755553311.JavaMail.zimbra@donzis.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Dec 05, 2021 at 07:52:33PM -0600, Lewis Donzis wrote: > > > ----- On Nov 30, 2021, at 7:42 AM, Bruce Richardson bruce.richardson@intel.com wrote: > > > On Mon, Nov 29, 2021 at 02:45:15PM -0600, Lewis Donzis wrote: > >> Hello. > >> We just upgraded from 21.08 to 21.11 and it's rather astounding the > >> number of incompatible changes in three months. Not a big deal, just > >> kind of a surprise, that's all. > >> Anyway, the problem is that the vmxnet3 driver is no longer functional > >> on FreeBSD. > >> In drivers/net/vmxnet3/vmxnet3_ethdev.c, vmxnet3_dev_start() gets an > >> error calling rte_intr_enable(). So it logs "interrupt enable failed" > >> and returns an error. > >> In lib/eal/freebsd/eal_interrupts.c, rte_intr_enable() is returning an > >> error because rte_intr_dev_fd_get(intr_handle) is returning -1. > >> I don't see how that could ever return anything other than -1 since it > >> appears that there is no code that ever calls rte_intr_dev_fd_set() > >> with a value other than -1 on FreeBSD. Also weird to me is that even > >> if it didn't get an error, the switch statement that follows looks like > >> it will return an error in every case. > >> Nonetheless, it worked in 21.08, and I can't quite see why the > >> difference, so I must be missing something. > >> For the moment, I just commented the "return -EIO" in vmxnet3_ethdev.c, > >> and it's now working again, but that's obviously not the correct > >> solution. > >> Can someone who's knowledgable about this mechanism perhaps explain a > >> little bit about what's going on? I'll be happy to help troubleshoot. > >> It seems like it must be something simple, but I just don't see it yet. > > > > Hi > > > > if you have the chance, it would be useful if you could use "git bisect" to > > identify the commit in 21.11 that broke this driver. Looking through the > > logs for 21.11 I can't identify any particular likely-looking commit, so > > bisect is likely a good way to start looking into this. > > > > Regards, > > /Bruce > > Hi, Bruce. git bisect is very time-consuming and very cool! > > I went back to 21.08, about 1100 commits, and worked through the process, but then I realized that I had forgotten to run ninja on one of the steps, so I did it again. > > I also re-checked it after the bisect, just to make sure that c87d435a4d79739c0cec2ed280b94b41cb908af7 is good, and 7a0935239b9eb817c65c03554a9954ddb8ea5044 is bad. > > Thanks, > lew > Many thanks for taking the time to do this. Adding Konstantin to thread as author of the commit you identified. Konstantin, any thoughts on this issue? /Bruce