From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F24F7A0C5A; Mon, 29 Nov 2021 14:59:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80D264068A; Mon, 29 Nov 2021 14:59:09 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 5328340689 for ; Mon, 29 Nov 2021 14:59:08 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10182"; a="236200493" X-IronPort-AV: E=Sophos;i="5.87,273,1631602800"; d="scan'208";a="236200493" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2021 05:59:07 -0800 X-IronPort-AV: E=Sophos;i="5.87,273,1631602800"; d="scan'208";a="458438049" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.81]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Nov 2021 05:59:05 -0800 Date: Mon, 29 Nov 2021 13:59:01 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Josh Soref , Josh Soref , dev@dpdk.org, David Marchand , Thomas Monjalon Subject: Re: [PATCH] Spelling Message-ID: References: <20211126195851.50167-1-jsoref@users.noreply.github.com> <737b8856-a247-3709-ad4c-a074d4547c86@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <737b8856-a247-3709-ad4c-a074d4547c86@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote: > On 11/26/2021 7:58 PM, Josh Soref wrote: > > diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c > > index ff7813f9..603e7c91 100644 > > --- a/app/test-eventdev/test_order_common.c > > +++ b/app/test-eventdev/test_order_common.c > > @@ -253,7 +253,7 @@ void > > order_opt_dump(struct evt_options *opt) > > { > > evt_dump_producer_lcores(opt); > > - evt_dump("nb_wrker_lcores", "%d", evt_nr_active_lcores(opt->wlcores)); > > + evt_dump("nb_worker_lcores", "%d", evt_nr_active_lcores(opt->wlcores)); > > Hi Josh, Thanks for the patch. > > The typo fixes for comments and logs are more straightforward, but I have > mixed feeling about the variable / macro typo fixes, let's see what others > think. > > And I think we should get this patch either one of the first patch or last > patch to prevent conflict with other patches. +1 to being a first patch to start things off clean. For the macros, since there is quick a bit of content in the patch, could we have the patch split into a separate patch for macro changes to review separately, allowing the simple doc/printf spelling changes to go in immediately?