From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 778A3A0C55; Tue, 30 Nov 2021 11:30:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D22C94113C; Tue, 30 Nov 2021 11:30:02 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 041E1410F7 for <dev@dpdk.org>; Tue, 30 Nov 2021 11:30:00 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10183"; a="223414883" X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="223414883" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 02:30:00 -0800 X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="499715427" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.37]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 30 Nov 2021 02:29:59 -0800 Date: Tue, 30 Nov 2021 10:29:55 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Radu Nicolau <radu.nicolau@intel.com> Cc: Kevin Laatz <kevin.laatz@intel.com>, dev@dpdk.org Subject: Re: [PATCH] dma/idxd: add allow/block list support Message-ID: <YaX9I17kdgIzK5h0@bricha3-MOBL.ger.corp.intel.com> References: <20211130095439.784229-1-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211130095439.784229-1-radu.nicolau@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Nov 30, 2021 at 09:54:39AM +0000, Radu Nicolau wrote: > Add support for allow or block list for devices bound > to the kernel driver. > When used the allow or block list applies as an additional > condition to the name prefix. > > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Minor comments inline below. > --- > doc/guides/dmadevs/idxd.rst | 10 ++++++++++ > drivers/dma/idxd/idxd_bus.c | 30 ++++++++++++++++++++++++++---- > 2 files changed, 36 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/dmadevs/idxd.rst b/doc/guides/dmadevs/idxd.rst > index d4a210b854..6201d4db1d 100644 > --- a/doc/guides/dmadevs/idxd.rst > +++ b/doc/guides/dmadevs/idxd.rst > @@ -117,6 +117,16 @@ the value used as the DPDK ``--file-prefix`` parameter may be used as a workqueu > name prefix, instead of ``dpdk_``, allowing each DPDK application instance to only > use a subset of configured queues. > > +Additionally, the -a (allowlist) or -b (blocklist) commandline parameters are > +also available to further restrict the device list that will be used. > +If the -a option is used then any device that passes the ``dpdk_`` or Should probably have a comma after "used", and then you can split the line at that point, having the rest of the sentence on one line. I believe longer lines are allowed for docs so long as we split them at punctuation points. > +``--file-prefix`` prefix condition must also be present in the allow list. > +Similarly, when the block list is used any device that passes the prefix > +condition must not be in the block list. Similarly for this sentence, can put comma and break after "used". > +For example, to only use ``wq0.3``, assuming the name prefix condition is met:: > + > + $ dpdk-test -a wq0.3 > + > Once probed successfully, irrespective of kernel driver, the device will appear as a ``dmadev``, > that is a "DMA device type" inside DPDK, and can be accessed using APIs from the > ``rte_dmadev`` library. <snip>