From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 187FAA00C2; Wed, 8 Dec 2021 17:59:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 995544111B; Wed, 8 Dec 2021 17:59:03 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id B54B2410F3 for ; Wed, 8 Dec 2021 17:59:02 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="217895259" X-IronPort-AV: E=Sophos;i="5.88,190,1635231600"; d="scan'208";a="217895259" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 08:58:00 -0800 X-IronPort-AV: E=Sophos;i="5.88,190,1635231600"; d="scan'208";a="503115757" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.78]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Dec 2021 08:57:57 -0800 Date: Wed, 8 Dec 2021 16:57:52 +0000 From: Bruce Richardson To: Jie Zhou Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Subject: Re: [PATCH v13 11/11] app/test: enable unit test on Windows Message-ID: References: <1638912263-7054-1-git-send-email-jizh@linux.microsoft.com> <1638928262-13177-1-git-send-email-jizh@linux.microsoft.com> <1638928262-13177-12-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1638928262-13177-12-git-send-email-jizh@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 07, 2021 at 05:51:02PM -0800, Jie Zhou wrote: > Enable a subset of unit tests for Windows CI > > - For driver tests, driver owners should enable corresponding tests when > enabling driver for Windows. For example, the cryptodev tests will be > enabled by "patch-18949: app/test: enable crypto unit tests on Windows" > (which depends on this patchset to be merged). > - For dump tests, currently the tests hang on Windows which require > further investigation. > > Signed-off-by: Jie Zhou > Mostly these changes look ok to me. One small query below. /Bruce > --- > app/test/meson.build | 111 ++++++++++++++++++++++--------------------- > 1 file changed, 58 insertions(+), 53 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 97ee83029e..fcf38729e7 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -1,12 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > -if is_windows > - build = false > # The following linkages are an exception to allow running the > # unit tests without requiring that the developer install the > # DPDK libraries. Explicit linkage of drivers (plugin libraries) > @@ -385,7 +390,7 @@ if dpdk_conf.has('RTE_LIB_METRICS') > test_sources += ['test_metrics.c'] > fast_tests += [['metrics_autotest', true]] > endif > -if dpdk_conf.has('RTE_LIB_TELEMETRY') > +if not is_windows and dpdk_conf.has('RTE_LIB_TELEMETRY') > test_sources += ['test_telemetry_json.c', 'test_telemetry_data.c'] > fast_tests += [['telemetry_json_autotest', true], ['telemetry_data_autotest', true]] If telemetry is enabled, is there a reason these won't run on Windows?