From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ED1FA0093; Thu, 9 Dec 2021 17:20:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C6DD4014F; Thu, 9 Dec 2021 17:20:30 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id C418E40041 for ; Thu, 9 Dec 2021 17:20:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639066829; x=1670602829; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=spuj5A/eMyejKnETy+oVpZcV7ClQSXQRmkiYbmGaGME=; b=YKBaSz+ORnLMxaYjIMIa1aPHODI3kzGcc2JOTauEml93F7qOI+E5MXCN ibNRJItWKAgeSHDFmv6AaYdqJatT+4qL0+jyTJDJPvww99Qh4n677QWKC 2QG3AlHyQkpmXQ+ML0/LrysDzrXcbUP8ddtiEP+VzdObaLRcxQl1dFJxW r6p/U71EWzC7+TyjULRWngWEh8i+RMCY++QfyYAz/NPRnxHozv9SbUJVc RKcM1N+w/Hf6+GUeNzUSgcw9Ae0H2p8X5j5VSvVJWfr/emUafDaWjkOET HBzYk6BNEGxBBC2Qqu0q/lNRcxZi9PNDK6uZNfyaG0M/nKHSFIw0aZe3P A==; X-IronPort-AV: E=McAfee;i="6200,9189,10193"; a="235649829" X-IronPort-AV: E=Sophos;i="5.88,192,1635231600"; d="scan'208";a="235649829" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2021 08:17:14 -0800 X-IronPort-AV: E=Sophos;i="5.88,192,1635231600"; d="scan'208";a="462189200" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.18.131]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Dec 2021 08:17:11 -0800 Date: Thu, 9 Dec 2021 16:17:08 +0000 From: Bruce Richardson To: Aaron Conole Cc: Jerin Jacob , Jie Zhou , dpdk-dev , Dmitry Kozlyuk , roretzla@microsoft.com, Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" , Pallavi Kadam , talshn@nvidia.com, Thomas Monjalon Subject: Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows Message-ID: References: <1638928262-13177-1-git-send-email-jizh@linux.microsoft.com> <1638990000-3228-1-git-send-email-jizh@linux.microsoft.com> <1638990000-3228-5-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 09, 2021 at 08:15:01AM -0500, Aaron Conole wrote: > Jerin Jacob writes: > > > On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: > >> > >> Even though test_interrupts.c can compile on Windows, skip interrupt > >> tests for now since majority of eal_interrupt on Windows are stubs. > >> Will remove the skip after interrupt being fully enabled on Windows. > >> > >> Signed-off-by: Jie Zhou > >> Acked-by: Dmitry Kozlyuk > >> > >> --- > >> app/test/test_interrupts.c | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c > >> index 2a05399f96..eec9b2805b 100644 > >> --- a/app/test/test_interrupts.c > >> +++ b/app/test/test_interrupts.c > >> @@ -12,6 +12,15 @@ > >> > >> #include "test.h" > >> > >> +#ifdef RTE_EXEC_ENV_WINDOWS > > > > Across the series, > > Instead of adding conditional compilation everywhere, Why not disable > > specific file > > for compilation for windows? > > Purpose of EAL to abstract the differences in execution environment > > and application > > should not know that. > > I think this was done because there would be two test lists in the meson > unit test file. But this is the second comment about these ifdef's, and > maybe we should revisit that discussion. Is there a different way to > accomplish not running the tests which are not appropriate for windows > builds, while not having two overlapping lists of unit tests in the > meson build file? > I'm wondering if a reasonable compromise solution might be to have the build system expose a usable RTE_EXEC_ENV symbol that can be used in C-code if statements rather than just in ifdefs. That would allow us to easily add e.g. if (RTE_EXEC_ENV == rte_env_linux) return TEST_SKIPPED; into each test function needing it. Two lines of C-code is a lot easier to add and manage than #ifdefs covering the whole file, or alternative lists in meson. /Bruce