From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7904A00C3; Wed, 15 Dec 2021 15:07:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E5B740688; Wed, 15 Dec 2021 15:07:48 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id D6C6E40041 for ; Wed, 15 Dec 2021 15:07:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639577266; x=1671113266; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cqzIgUNXTePq1gJORIGnPyv9p/u/FbX+Up8/Irqf8JQ=; b=ahyRxlUDyzBXo9rbni3YRFtvp+W1Wn89Qf80xvFGEoJPc334TOfvHObS 9bdiDwkaRb48KoSNYeJm3YEt+myPEobLsdpWahjWyXDAfXBdU4kbqJT8S Azomk9RztPmypQKg6gI/ciLQ42Bj27t0ncu216oB6f/gDckYuQ9qPe1Uv qccIomASDDxCcyFp9IVU+yA7ieiR1V6jdJNxzI8gwi4hJaHgY2ok0BwJI KYf8x0UOZg77a/sVRU3hnPd1lIIpH9ePu65NPIYH/pNYsPhx/mgj1o8Yg 8TtJ7Kz9Xxu+X1Ce0XYTky2q90uGXyUDnJE+xUNkSYf8uWieBWMhGlmNh Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="226091008" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="226091008" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:07:44 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="505811221" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.7.115]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Dec 2021 06:07:43 -0800 Date: Wed, 15 Dec 2021 14:07:40 +0000 From: Bruce Richardson To: Jerin Jacob Cc: Ronan Randles , dpdk-dev , "Van Haaren, Harry" Subject: Re: [PATCH 00/12] add packet generator library and example app Message-ID: References: <20211214141242.3383831-1-ronan.randles@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 15, 2021 at 06:01:23PM +0530, Jerin Jacob wrote: > On Tue, Dec 14, 2021 at 7:42 PM Ronan Randles wrote: > > > > This patchset introduces a Gen library for DPDK. This library provides an easy > > way to generate traffic in order to test software based network components. > > > > This library enables the basic functionality required in the traffic generator. > > This includes: raw data setting, packet Tx and Rx, creation and destruction of a > > Gen instance and various types of data parsing. > > This functionality is implemented in "lib/gen/rte_gen.c". IPv4 parsing > > functionality is also added in "lib/net/rte_ip.c", this is then used in the gen > > library. > > > > A sample app is included in "examples/generator" which shows the use of the gen > > library in making a traffic generator. This can be used to generate traffic by > > running the dpdk-generator generator executable. This sample app supports > > runtime stats reporting (/gen/stats) and line rate limiting > > (/gen/mpps,) through telemetry.py. > > > > > > lib/gen/rte_gen.h | 114 +++++++ > > Please check Doxygen syntax across the file. rte_gen_create(), > rte_gen_destroy(), > rte_gen_packet_parse_string() etc missing proper doxygen synax. If you do a build with "-Denable_docs=true -Dwerror" meson options set, these should all be flagged on build. [If they aren't, we should fix!] /Bruce