From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79A7EA04AB; Mon, 24 Jan 2022 17:11:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1405341157; Mon, 24 Jan 2022 17:11:23 +0100 (CET) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id 0DFB140040 for ; Mon, 24 Jan 2022 17:11:22 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id h29so11878717wrb.5 for ; Mon, 24 Jan 2022 08:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jSsYfWxVQAdSjQs9iI4uhKffkTa1CjI5sgy4IPu5nJY=; b=VN5cKNYi1D1iQBM2zn/H15NxRuluqqi7LwvvRR3H6CoVd97ZcSjy/AxYGIJ/XqnEFT GyHm2kzPJ8gv1NMT4IDQ80CJJEbX0ZZy/bUXgOhfkr0jjt2sVtJuAeu4pALGieNd6eZ3 NTEIiIFQNs1PQVo7TAkgu7nTzeFEq9LAe49FJ8FKCUIJLc5bG/HOwgr2+NIZR4JuMDso tjL/FOdADEIF58hEflUlXLV74USu31afPqoqEOoFM4edGSQ0Mquku3Fz+JVaYvDraLQd QFlo9DpJTZhoYKF1/jEoTZrrOep0IgXwGMWrKGD3kvJVPeRdMV6/F1d+65KGx2/d71ca cECw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jSsYfWxVQAdSjQs9iI4uhKffkTa1CjI5sgy4IPu5nJY=; b=16ZDEgpQQlva8Htf6DWLfxGMVAAhiZT/nPH4z5E9nCEBUOfSGY2HBPBjRbpRRTxm82 jSvACicZ3XZG7zqnrCGM2G1jVJb4AnNlOZAChuiw1QFGiyvtSwj88gTzul7d9VeJE16z A88iwg1Ej0LkCvhb3aUNTgnRjeYzYbplXhtDN11wi/NFfqxDYdADyv8KLfOVYbET8L5+ rIlYAO4i+9ZNsUcOpM0MlYsZ3l3GS3hwZJIxc0cy/UGXSTp9LnaFLRmhfMQerxugw8uc x1UuoRRkgzdfj7V7N/9pYKoZeIKscFDe7F+AlR0KeyflWhYLYsNVbnuVeR/7c1yWmfg5 qOLg== X-Gm-Message-State: AOAM533cEYzJQkpj+lOKgbZqh0VrQKXLVJOysal5pVOXml/2n3sltbwG xwMpUW3fvDes8XPRo3N2u0H6Xg== X-Google-Smtp-Source: ABdhPJwqouD8a0Z334gXxtgBPYmaUDCR6Ee/7VFNH4oOsqE8deSGvAUSHp/EQfdMIieciNxB7xsXOg== X-Received: by 2002:a5d:4f84:: with SMTP id d4mr14384139wru.162.1643040681793; Mon, 24 Jan 2022 08:11:21 -0800 (PST) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id v3sm6845004wru.15.2022.01.24.08.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 08:11:20 -0800 (PST) Date: Mon, 24 Jan 2022 17:11:20 +0100 From: Olivier Matz To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, jerinjacobk@gmail.com, dev@dpdk.org Subject: Re: [PATCH] mempool: fix get objects from mempool with cache Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35D86DB2@smartserver.smartshare.dk> <20220114163650.94288-1-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 24, 2022 at 04:38:58PM +0100, Olivier Matz wrote: > On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > > --- a/lib/mempool/rte_mempool.h > > +++ b/lib/mempool/rte_mempool.h > > @@ -1443,6 +1443,10 @@ rte_mempool_put(struct rte_mempool *mp, void *obj) > > > > /** > > * @internal Get several objects from the mempool; used internally. > > + * > > + * If cache is enabled, objects are returned from the cache in Last In First > > + * Out (LIFO) order for the benefit of CPUs with small L1 cache. > > + * > > * @param mp > > * A pointer to the mempool structure. > > * @param obj_table > > @@ -1452,7 +1456,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj) > > * @param cache > > * A pointer to a mempool cache structure. May be NULL if not needed. > > * @return > > - * - >=0: Success; number of objects supplied. > > + * - 0: Success; got n objects. > > * - <0: Error; code of ring dequeue function. > > */ > > static __rte_always_inline int > > I think that part should be in a separate commit too. This is a > documentation fix, which is easily backportable (and should be > backported) (Fixes: af75078fece3 ("first public release")). I see that the same change is also part of this commit: https://patches.dpdk.org/project/dpdk/patch/20211223100741.21292-1-chenzhiheng0227@gmail.com/ I think it is better to have a doc fix commit, and remove this chunk from this patch.