From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1C26A034E; Wed, 19 Jan 2022 18:27:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B13A241181; Wed, 19 Jan 2022 18:27:49 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id DF50241147 for ; Wed, 19 Jan 2022 18:27:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642613268; x=1674149268; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hB8Vv9AzD2GtRzEzSB2OcoWuWwsnEiFDF9v9Q1SN/Xo=; b=PHd6b5knjMdpPrqfxtQoMME1OAeWwL1YHIVXcmpFicheWI1Tmt5aJVc4 SprqZE7xD4Y++i0LXhRzBW+Ft2gMfIJcPFyDwhUOfsDBW9av8O7cL/kZ8 n6pWCq6elB6beDJ2fnxo54F7Kjp6TudxocWqkZg6Z6e/Bml3JIk/rrpVb 6/E2vClwCv7JCMAyulDvSoaVegF9xGlU1j/mOK8b9/umXNnSj6CuYTCDm 1YhPxGJGr75VLyMS7IrpEEN/O4r08j8UXoF9+fesvcyH5jPkhhbazdJ17 2uC5DIu/5fDTJOOcpfEE/qszRillxSUPisDYtI5deS8mSUH4D6hPLV6Dy A==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="245320459" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="245320459" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 09:25:42 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="625961071" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.2.226]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Jan 2022 09:25:41 -0800 Date: Wed, 19 Jan 2022 17:25:37 +0000 From: Bruce Richardson To: David Marchand Cc: dev Subject: Re: [PATCH 2/6] app/test: link unit test binary against all available libs Message-ID: References: <20220113173918.2700651-1-bruce.richardson@intel.com> <20220113173918.2700651-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 19, 2022 at 05:51:20PM +0100, David Marchand wrote: > On Thu, Jan 13, 2022 at 6:40 PM Bruce Richardson > wrote: > > > > Rather than maintaining a list of the libraries the unit tests need, and > > having to conditionally include/omit optional libs from the list, we can > > just link against all available libraries, simplifying the code > > considerably. > > > > Signed-off-by: Bruce Richardson > > --- > > app/test/meson.build | 47 +------------------------------------------- > > 1 file changed, 1 insertion(+), 46 deletions(-) > > > > diff --git a/app/test/meson.build b/app/test/meson.build > > index 344a609a4d..9919de4307 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -157,39 +157,7 @@ test_sources = files( > > 'virtual_pmd.c', > > ) > > > > -test_deps = [ > > - 'acl', > > - 'bus_pci', > > - 'bus_vdev', > > bus_pci and bus_vdev are not "libraries", but "drivers" dependencies > and must be kept. > This probably explains an error seen in UNH test report for a job that > disables all but those bus drivers and net/hns3: > http://mails.dpdk.org/archives/test-report/2022-January/251477.html > Thanks for flagging this, I'll update the set. /Bruce