From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A194FA034C; Thu, 20 Jan 2022 12:37:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D075426E5; Thu, 20 Jan 2022 12:37:52 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5F65040042 for ; Thu, 20 Jan 2022 12:37:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642678670; x=1674214670; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=15xCp9q3R4/gN8/XbdHkp9MasKlvqjxFPOORHeGM2lk=; b=IDk1NNs7YH+6kj5kmL382lvVjrTFDKH1ibhPDKFRrawa49mSBDwx5SjJ 4kXtQVqTZAqEJQ5oziTxNImLnHhpKZ6DI5HdJ9Q6AvIJMN1jh9UfiTfUJ TvTR9Y4PJ6LZ7Ik/CxeM+EMZJo28fa8J+ilbP9L0EIzxQ2PJacIGIO6Sj XC42itye+1IuuQu5AAg16Paq4bPZaFjkdw1Dqtztvn7onO/nKAm3ujXYg 7xCMeDO3kroseiP0D+pU1weEPEMgQPBaeSguf0eemGvr/LSI6EmpqY0Fn RUiqKCtX1txynaKQqGYJ0UKAmkuxXzLYqNhjB0XiWI1gposWVR3FmwtHX w==; X-IronPort-AV: E=McAfee;i="6200,9189,10232"; a="245124664" X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="245124664" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 03:37:45 -0800 X-IronPort-AV: E=Sophos;i="5.88,302,1635231600"; d="scan'208";a="532738713" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.29.19]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Jan 2022 03:37:43 -0800 Date: Thu, 20 Jan 2022 11:37:40 +0000 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, Ferruh Yigit , Stephen Hemminger , Long Li , Maxime Coquelin , Chenbo Xia , Nipun Gupta , Xiao Wang Subject: Re: [PATCH] build: remove custom dependency checks in drivers Message-ID: References: <20220120105421.27200-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220120105421.27200-1-david.marchand@redhat.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 20, 2022 at 11:54:21AM +0100, David Marchand wrote: > Some drivers currently have their own checks and give some non > consistent reasons when an internal dependency is unavailable. > > drivers/meson.build also checks for internal dependencies via 'deps'. > Let's rely on it for consistency, and smaller code. > > Signed-off-by: David Marchand > --- Thanks for the cleanup. Acked-by: Bruce Richardson