From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05F65A034F; Fri, 4 Feb 2022 15:50:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4F674013F; Fri, 4 Feb 2022 15:49:59 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C9EA240041 for ; Fri, 4 Feb 2022 15:49:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643986199; x=1675522199; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=aUp6lSHNZielLgi+C1WMFD+VG2pzFArhT0sDQ8nENcY=; b=PIm+Es3RdeiWoAqlRd0Iv+N71RHufmNPx2zNv2CGy2TsHlsahuV7qpTo zhiX9qrt7Vq36qUluR6Ik3Q0TlF+n2RFvEokW2vBuol7Trjb9nDA40fs5 3w2mx0SOULstKZV7hsqx2Uh6F38SM2B19wpGSK4erlS3y00vi6m0xlZ77 0UM8v53phDh8AT6qRt8mq7+ZjI/pKyF1ByCK7QCbjFB9RCRfOMA7eNvV4 UZjMZsaK2585nXEB0jcYKvfkHjA33godpT+IoVi2TR0Nye+RPxgpupE6X sQVgPVlA9y4ttaChpUNkNCJgwZHpWmhkB+IQTnYpNAbI7fXKEbCAvCRzS w==; X-IronPort-AV: E=McAfee;i="6200,9189,10247"; a="272879074" X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="272879074" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2022 06:49:57 -0800 X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="539187063" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.8.163]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Feb 2022 06:49:56 -0800 Date: Fri, 4 Feb 2022 14:49:52 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Robert Sanford , dev@dpdk.org, chas3@att.com, humin29@huawei.com Subject: Re: [PATCH v2 7/8] net/ring: add promisc and all-MC stubs Message-ID: References: <1639592401-56845-2-git-send-email-rsanford@akamai.com> <1640116650-3475-1-git-send-email-rsanford@akamai.com> <1640116650-3475-8-git-send-email-rsanford@akamai.com> <532bfd7f-34ff-620f-8a9a-487864d40754@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <532bfd7f-34ff-620f-8a9a-487864d40754@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 04, 2022 at 02:36:47PM +0000, Ferruh Yigit wrote: > On 12/21/2021 7:57 PM, Robert Sanford wrote: > > Add promiscuous_enable, promiscuous_disable, allmulticast_enable, > > and allmulticast_disable API stubs. > > This helps clean up errors in dpdk-test link_bonding_mode4_autotest. > > > > Signed-off-by: Robert Sanford > > --- > > drivers/net/ring/rte_eth_ring.c | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c > > index db10f03..cfb81da 100644 > > --- a/drivers/net/ring/rte_eth_ring.c > > +++ b/drivers/net/ring/rte_eth_ring.c > > @@ -226,6 +226,30 @@ eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused, > > } > > static int > > +eth_promiscuous_enable(struct rte_eth_dev *dev __rte_unused) > > +{ > > + return 0; > > +} > > + > > +static int > > +eth_promiscuous_disable(struct rte_eth_dev *dev __rte_unused) > > +{ > > + return 0; > > +} > > + > > +static int > > +eth_allmulticast_enable(struct rte_eth_dev *dev __rte_unused) > > +{ > > + return 0; > > +} > > + > > +static int > > +eth_allmulticast_disable(struct rte_eth_dev *dev __rte_unused) > > +{ > > + return 0; > > +} > > + > > +static int > > eth_link_update(struct rte_eth_dev *dev __rte_unused, > > int wait_to_complete __rte_unused) { return 0; } > > @@ -275,6 +299,10 @@ static const struct eth_dev_ops ops = { > > .stats_reset = eth_stats_reset, > > .mac_addr_remove = eth_mac_addr_remove, > > .mac_addr_add = eth_mac_addr_add, > > + .promiscuous_enable = eth_promiscuous_enable, > > + .promiscuous_disable = eth_promiscuous_disable, > > + .allmulticast_enable = eth_allmulticast_enable, > > + .allmulticast_disable = eth_allmulticast_disable, > > not sure about adding dummy dev_ops to the driver for the unit test, > what about updating 'link_bonding_mode4_autotest' accordingly? > > Bruce (net/ring maintainer), what do you think about dummy dev_ops? For something like ring PMD, I don't see an issue with it, since they don't really have any meaning for a ring PMD, they might as well just return success rather than having application code have to handle errors from them. Acked-by: Bruce Richardson