From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2AD9A0032; Fri, 18 Feb 2022 10:41:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E2EC40E28; Fri, 18 Feb 2022 10:41:46 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id AB4A340150 for ; Fri, 18 Feb 2022 10:41:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645177305; x=1676713305; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=eAbmgA337fCt0p/uGFxSU92hLOn8p0WgtpcbX58zJt8=; b=aWhTzSdhgiiYPs6YpoUqjsa7aZr+OuaPTH0JqqslOXgioqzJgTJgOcGy si8F3Ysm+lXRa9rhEeTPXNkYyssHFwpoT8WHUAQdPDG6yP1hExg3RAP3f kcHdEV/7ijRX7jOCtOCQ3JB6diJbUsf7lHpR7LdMZyWCabIo9Of5KoOi/ fUJ0qz0IKj6KDwyXIj56o1NIAC0CvJ9CrMNSzvjgvG+NCEKlGISwjVX9b maDc9g7sOf4mESQ2k47GiQOGXca5yG+FtDqBC52COhKf3QA5btdXLZ9OL lWn2TRRutBHA6dk/O8BhPdeLFoEEyAAp5vSvWav3TzFNt02VSdqmaCzG9 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="250849940" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="250849940" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 01:41:44 -0800 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="637691599" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.174]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 Feb 2022 01:41:43 -0800 Date: Fri, 18 Feb 2022 09:41:39 +0000 From: Bruce Richardson To: "Ma, WenwuX" Cc: "Burakov, Anatoly" , "dev@dpdk.org" , "Hu, Jiayu" , "Wang, Yinan" , "He, Xingguang" Subject: Re: [PATCH] examples/multi_process: add options to control port configuration Message-ID: References: <20220217151755.442306-1-wenwux.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 18, 2022 at 06:49:19AM +0000, Ma, WenwuX wrote: > > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: 2022年2月17日 17:06 > > To: Ma, WenwuX > > Cc: Burakov, Anatoly ; dev@dpdk.org; Hu, > > Jiayu ; Wang, Yinan ; He, > > Xingguang > > Subject: Re: [PATCH] examples/multi_process: add options to control port > > configuration > > > > On Thu, Feb 17, 2022 at 03:17:55PM +0000, Wenwu Ma wrote: > > > The default values of rx mq_mode and rx offloads for port will cause > > > symmetric_mp startup failure if the port do not support rss or csum. > > > Therefore, we added two new options --rx-mq-mode and --rx-offloads, > > > through which the user can set the values appropriately according to > > > the situation to make app startup normally. > > > > > > Signed-off-by: Wenwu Ma --- > > > > The idea seems reasonable enough, but I think the implementation requiring > > the user to pass in special "magic numbers" for the offload values is not a > > good idea. Perhaps add in a separate flag for "no-csum" to disable that. > > > > For the no-rss case, can you explain how you would see this app being used > > in the absense of RSS support to distribute traffic among the separate > > processes? > > When app run in qemu vm and the backend is dpdk vhost, it will report error below: > "virtio_dev_configure(): RSS support requested but not supported by the device" Sure, I understand that. But how does it make sense to run multiple copies of the app if RSS cannot be used to spread the traffic between the instances?