DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Weiguo Li <liwg06@foxmail.com>
Cc: dev@dpdk.org, shreyansh.jain@nxp.com
Subject: Re: [PATCH 1/6] bus/dpaa: fix the curly braces mismatch problem
Date: Mon, 7 Feb 2022 09:26:39 +0000	[thread overview]
Message-ID: <YgDlz2pI6/g7o8op@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <tencent_11E278C24E0122CE74ECBE0347A845C06209@qq.com>

On Sun, Feb 06, 2022 at 08:44:09AM +0800, Weiguo Li wrote:
> Supplement the missing half of braces for the extern "C" block
> 
> Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations")
> Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
> Cc: shreyansh.jain@nxp.com
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
>  drivers/bus/dpaa/include/fsl_fman.h | 5 +++++
>  drivers/bus/dpaa/rte_dpaa_bus.h     | 4 ++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/bus/dpaa/include/fsl_fman.h b/drivers/bus/dpaa/include/fsl_fman.h
> index acb344584f..a10845f0a0 100644
> --- a/drivers/bus/dpaa/include/fsl_fman.h
> +++ b/drivers/bus/dpaa/include/fsl_fman.h
> @@ -186,4 +186,9 @@ static inline void fman_if_disable_all_rx(void)
>  	list_for_each_entry(__if, fman_if_list, node)
>  		fman_if_disable_rx(__if);
>  }
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
>  #endif /* __FSL_FMAN_H */

Judging from the filename, this looks to be an internal-only header. Does
it really need the c++ guards?

/Bruce

  reply	other threads:[~2022-02-07  9:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220206004414.2801177-1-liwg06@foxmail.com>
2022-02-06  0:44 ` Weiguo Li
2022-02-07  9:26   ` Bruce Richardson [this message]
2022-02-06  0:44 ` [PATCH 2/6] common/mlx5: " Weiguo Li
2022-02-06  0:44 ` [PATCH 3/6] net/cxgbe: " Weiguo Li
2022-02-06  0:44 ` [PATCH 4/6] net/dpaa2: " Weiguo Li
2022-02-06  0:44 ` [PATCH 5/6] eal/windows: " Weiguo Li
2022-02-06 16:23   ` Dmitry Kozlyuk
2022-02-07 11:43   ` Weiguo Li
2022-02-06  0:44 ` [PATCH 6/6] eventdev: remove C++ include guard from private header Weiguo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgDlz2pI6/g7o8op@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=liwg06@foxmail.com \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).