From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 302B2A034F; Mon, 7 Feb 2022 10:26:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1050410EA; Mon, 7 Feb 2022 10:26:46 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id E36BF40DDA for ; Mon, 7 Feb 2022 10:26:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644226005; x=1675762005; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0w0heJw2tZoD9FRmlIo85eF9zUw0094Vhyyc9IZEKYc=; b=cwaHGeHW2KDD008T64jOsc1BwaLh6yCVbFCpIOKwK5fLc81gJW32FKb0 IAwgDLRYL7MIs649WLLa+ZAzi9arNEpR32fZlNsydEwv+NFmN5WX1qNpg el9rXuzA6X33kW+eQ1HKPoCooPcw+26A9L850/WrpzdlWohPSP/IsJ/z4 DFGjvCRmIdeWtJZhC3eLkR81VsVe1+9m27x7uvSP/iLc24TyTkt7ylWwv 80xY59sSI8OF8OFTYbGZ1azX9LkasiCUpLGNVt5mUDo40/4in3ZRtA3v/ t5BmPnTecGrzTq69ctChaG4ftR5u1OlafputsVocl5uNA2OGAOmIKUQWi Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="309423656" X-IronPort-AV: E=Sophos;i="5.88,349,1635231600"; d="scan'208";a="309423656" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 01:26:43 -0800 X-IronPort-AV: E=Sophos;i="5.88,349,1635231600"; d="scan'208";a="481522675" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.10.89]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Feb 2022 01:26:42 -0800 Date: Mon, 7 Feb 2022 09:26:39 +0000 From: Bruce Richardson To: Weiguo Li Cc: dev@dpdk.org, shreyansh.jain@nxp.com Subject: Re: [PATCH 1/6] bus/dpaa: fix the curly braces mismatch problem Message-ID: References: <20220206004414.2801177-1-liwg06@foxmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Feb 06, 2022 at 08:44:09AM +0800, Weiguo Li wrote: > Supplement the missing half of braces for the extern "C" block > > Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations") > Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton") > Cc: shreyansh.jain@nxp.com > > Signed-off-by: Weiguo Li > --- > drivers/bus/dpaa/include/fsl_fman.h | 5 +++++ > drivers/bus/dpaa/rte_dpaa_bus.h | 4 ++++ > 2 files changed, 9 insertions(+) > > diff --git a/drivers/bus/dpaa/include/fsl_fman.h b/drivers/bus/dpaa/include/fsl_fman.h > index acb344584f..a10845f0a0 100644 > --- a/drivers/bus/dpaa/include/fsl_fman.h > +++ b/drivers/bus/dpaa/include/fsl_fman.h > @@ -186,4 +186,9 @@ static inline void fman_if_disable_all_rx(void) > list_for_each_entry(__if, fman_if_list, node) > fman_if_disable_rx(__if); > } > + > +#ifdef __cplusplus > +} > +#endif > + > #endif /* __FSL_FMAN_H */ Judging from the filename, this looks to be an internal-only header. Does it really need the c++ guards? /Bruce