From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73AECA0352; Tue, 8 Feb 2022 19:10:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4441C41140; Tue, 8 Feb 2022 19:10:52 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 7BC284111B for ; Tue, 8 Feb 2022 19:10:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644343850; x=1675879850; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Gl1StIX/ZCq6CsPVpYfm5+wV2P6s8wap5NohEqUL3GQ=; b=Q2hX59MJyEj9LN/EoVxSRtsZZy+wVZfZjSwk4ynK3ceKC3b1ZMOpKloG ryqPiyo8lWoOmTQcYWl7ijU9u8B2uwZd6MYtjPkRB5HeIo4nCvo//0ilC 6DprAuGBV3WjURYKv/hYg1sZtRC20pGwsEJzRVPfOe2Loeolnrn+Cm0XE qmACxqRDXd5uisPGNIHM/fS9AmzpwYDtKrIBEDNG6Ox9LQoZjNbwL0Bse QTk+N5kUpZJuuaF3ThjOId4ngu6T5D30IdJ3iYCJj3HjGHHnZmwNjPAgR 3EYO+T7GDwCKjRt8Tc3GArA+y8kPdlQe7upNktNAPowXldZtRhW8YgquB A==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="246601097" X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="246601097" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 10:10:49 -0800 X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="632931883" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.9.238]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Feb 2022 10:10:46 -0800 Date: Tue, 8 Feb 2022 18:10:43 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: "Medvedkin, Vladimir" , "Ananyev, Konstantin" , "Morrissey, Sean" , "dev@dpdk.org" Subject: Re: [PATCH v5 0/2] Add config file support for l3fwd Message-ID: References: <20220126124459.2469838-1-sean.morrissey@intel.com> <20220204195905.449192-1-sean.morrissey@intel.com> <20220204142636.6250f05c@hermes.local> <20220207190419.2a1ca44b@hermes.local> <5a01520b-b85a-02c7-67eb-5a7119e46ada@intel.com> <20220208094904.5ca9db4c@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220208094904.5ca9db4c@hermes.local> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 08, 2022 at 09:49:04AM -0800, Stephen Hemminger wrote: > On Tue, 8 Feb 2022 16:15:15 +0000 > "Medvedkin, Vladimir" wrote: > > > >> Or have a generic library for reading LPM entries. L3fwd is supposed > > >> to be as small as possible (it no longer is), and the real work should > > >> be done by libraries to make it easier to build other applications. > > > > > > I never heard users ask about such thing, > > > but if there is a demand for that, then I suppose it could be considered. > > > CC-ing LPM/FIB maintainers to comment. > > > Though I believe it should be a subject of separate patch and discussion > > > (I think many questions will arise - what format should be, how to support > > > different types of user-data, to make it generic enough, etc.). > > > > Agree, it is very application specific, so it could be really difficult > > to make it generic. > > But several other also have LPM tables, so why not have common code for other applications. > > examples/l3fwd-power/main.c > examples/ipsec-secgw/rt.c > examples/ip_fragmentation/main.c > examples/l3fwd/l3fwd_lpm.c > examples/ip_reassembly/main.c Could we perhaps add a "load" function to the lpm library itself?